Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEMP] Bad test #26472

Closed
wants to merge 7 commits into from
Closed

[TEMP] Bad test #26472

wants to merge 7 commits into from

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Mar 24, 2023

Summary

How did you test this change?

Implements waitForCommitToBeReady for resources.

currently it is only opted into when a special prop is passed. This will be removed in the next commit when I update all the tests that now require different mechanics to simulate resource loading.

The general approach is to track how many things we are waiting on and when we hit zero proceed with the commit. For Float CSS in particular we wait for all stylesheet preloads before inserting any uninserted stylesheets. When all the stylesheets have loaded we continue the commit as usual.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 25, 2023
@gnoff gnoff closed this Mar 25, 2023
@gnoff gnoff deleted the bad-test branch March 25, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants