Fix LocalEventTrapMixin for Bad Tree State#2894
Merged
Merged
Conversation
yungsters
force-pushed
the
local-event-trap-mixin
branch
2 times, most recently
from
d1eff9e to
590e655
Compare
Collaborator
There was a problem hiding this comment.
Add a comment here explaining that this can be null if a React component elsewhere in the tree fatals?
Collaborator
|
lgtm |
Summary: If `getDOMNode()` returns null in `LocalEventTrapMixin`, `listener` will also be null and `accumulateInto` will throw. This changes `LocalEventTrapMixin` to throw a more helpful error message. Test Plan: Ran unit test successfully: ``` npm test LocalEventTrapMixin-test.js ```
yungsters
force-pushed
the
local-event-trap-mixin
branch
from
590e655 to
a7aca51
Compare
yungsters
added a commit
that referenced
this pull request
Jan 21, 2015
Fix LocalEventTrapMixin for Bad Tree State
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
If
getDOMNode()returns null inLocalEventTrapMixin,listenerwill also be null andaccumulateIntowill throw.getDOMNode()can return null if a React component elsewhere in the tree fatals and causes a set of mounted components to be in a bad state.Test Plan:
Ran unit test successfully: