Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fiber] Support moveBefore at the top level of a container #32036

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Jan 9, 2025

Parity with appendChild and insertBefore. This allows reordering at the root while preserving state.

@sebmarkbage sebmarkbage requested a review from gnoff January 9, 2025 21:22
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 9, 2025
@react-sizebot
Copy link

Comparing: d2a1b88...d243516

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 513.98 kB 513.98 kB = 91.79 kB 91.79 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 548.08 kB 548.01 kB = 97.52 kB 97.51 kB
facebook-www/ReactDOM-prod.classic.js = 595.86 kB 595.86 kB = 104.87 kB 104.87 kB
facebook-www/ReactDOM-prod.modern.js = 586.29 kB 586.29 kB = 103.32 kB 103.32 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-prod.fb.js +0.89% 379.36 kB 382.72 kB +0.99% 65.85 kB 66.50 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +0.87% 384.79 kB 388.16 kB +1.00% 66.80 kB 67.47 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.83% 404.85 kB 408.21 kB +0.95% 69.70 kB 70.36 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +0.82% 410.25 kB 413.62 kB +0.91% 70.62 kB 71.26 kB

Generated by 🚫 dangerJS against dfbceb9

@sebmarkbage sebmarkbage merged commit 056073d into facebook:main Jan 9, 2025
188 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
Parity with appendChild and insertBefore. This allows reordering at the
root while preserving state.

DiffTrain build for [056073d](056073d)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Jan 10, 2025
…32036)

Parity with appendChild and insertBefore. This allows reordering at the
root while preserving state.

DiffTrain build for [056073d](facebook@056073d)
@Hardelzs
Copy link

This development is significant for web developers, as it offers a more efficient way to manage dynamic content updates without losing the current state of elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants