Korean translation for docs #3240

Merged
merged 52 commits into from Mar 27, 2015

Conversation

Projects
None yet
@sairion
Contributor

sairion commented Feb 23, 2015

Fixes #2945

By this PR, 26 out of 39 docs entry will be provided as Korean as well. (tracker: reactkr/discuss#4)

P.S.
We kept most of Chinese translator's convention, but would like to introduce another PR for docs internalization. I think cherry-picking from #2876 seems to be a good start point!

@disjukr

This comment has been minimized.

Show comment
Hide comment

disjukr commented Feb 24, 2015

+1

@AiOO

This comment has been minimized.

Show comment
Hide comment

AiOO commented Feb 24, 2015

👍

@yeun

This comment has been minimized.

Show comment
Hide comment

yeun commented Feb 24, 2015

👍

@jisunjessica

This comment has been minimized.

Show comment
Hide comment

👍👍

@Kroisse

This comment has been minimized.

Show comment
Hide comment
@Kroisse

Kroisse Feb 27, 2015

👍👍👍

Kroisse commented Feb 27, 2015

👍👍👍

sairion and others added some commits Jan 26, 2015

translate 10.6-update.ko-KR.md
apply comments

apply comments

apply comments
@sairion

This comment has been minimized.

Show comment
Hide comment
@sairion

sairion Mar 11, 2015

Contributor

Korean translation of React docs is complete, and updated with the most recent one (at this moment of writing).

We have also launched Korean docs GH page :) (but still want to be officialy accepted, of course!):

@zpao Any updates?

Contributor

sairion commented Mar 11, 2015

Korean translation of React docs is complete, and updated with the most recent one (at this moment of writing).

We have also launched Korean docs GH page :) (but still want to be officialy accepted, of course!):

@zpao Any updates?

@marocchino

This comment has been minimized.

Show comment
Hide comment
@marocchino

marocchino Mar 27, 2015

Contributor

@zpao Korean translate team members all agree with cla. You can see full the members list here. ( reactkr/react#55 ) If you still have a reason that you can not merge this pr. please tell us. We will fix it.

Contributor

marocchino commented Mar 27, 2015

@zpao Korean translate team members all agree with cla. You can see full the members list here. ( reactkr/react#55 ) If you still have a reason that you can not merge this pr. please tell us. We will fix it.

@zpao

This comment has been minimized.

Show comment
Hide comment
@zpao

zpao Mar 27, 2015

Member

Alright, let's do it. Sorry for the delay, it's been a bit crazy around here recently with react native :)

Member

zpao commented Mar 27, 2015

Alright, let's do it. Sorry for the delay, it's been a bit crazy around here recently with react native :)

zpao added a commit that referenced this pull request Mar 27, 2015

@zpao zpao merged commit e30dd83 into facebook:master Mar 27, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zpao

This comment has been minimized.

Show comment
Hide comment
@zpao

zpao Mar 27, 2015

Member

Ok, now moving forwards (and this is something we need to figure out a bit more across translations but I'm here), I really like the update in batches approach. Some things we'll definitely encourage that we fix across locales (eg, my change in #3487 would have been done to the ko-KR page as well), but others just won't be possible. I think it would be awesome to keep an eye on changes to docs (perhaps on a weekly basis just looking at https://github.com/facebook/react/commits/master/docs) and submitting changes in batches.

Looking further ahead, I've had https://github.com/screeninteraction/jekyll-multiple-languages-plugin open in a tab for a long time now, it might be time to finally look at integrating that. We have 3 translations at the moment - zh-CN, ja-JP, ko-KR - and while they aren't all complete, it would be great to integrate them into the site more holistically. Ultimately I'd like to move away from Jekyll to something node-based (and preferably using React, as we're doing in most of our other docs sites). We might have to write out own i18n stuff to make that work though.

If anybody is interested in taking on the larger project here and I'll try to give some guidance and thoughts.

Member

zpao commented Mar 27, 2015

Ok, now moving forwards (and this is something we need to figure out a bit more across translations but I'm here), I really like the update in batches approach. Some things we'll definitely encourage that we fix across locales (eg, my change in #3487 would have been done to the ko-KR page as well), but others just won't be possible. I think it would be awesome to keep an eye on changes to docs (perhaps on a weekly basis just looking at https://github.com/facebook/react/commits/master/docs) and submitting changes in batches.

Looking further ahead, I've had https://github.com/screeninteraction/jekyll-multiple-languages-plugin open in a tab for a long time now, it might be time to finally look at integrating that. We have 3 translations at the moment - zh-CN, ja-JP, ko-KR - and while they aren't all complete, it would be great to integrate them into the site more holistically. Ultimately I'd like to move away from Jekyll to something node-based (and preferably using React, as we're doing in most of our other docs sites). We might have to write out own i18n stuff to make that work though.

If anybody is interested in taking on the larger project here and I'll try to give some guidance and thoughts.

@marocchino

This comment has been minimized.

Show comment
Hide comment
@marocchino

marocchino Mar 27, 2015

Contributor

We already doing weekly update in here. It need to rebase with master but, hopefully We can send PR tomorrow. so.. dont worry about update translation. 😄

Contributor

marocchino commented Mar 27, 2015

We already doing weekly update in here. It need to rebase with master but, hopefully We can send PR tomorrow. so.. dont worry about update translation. 😄

@zpao

This comment has been minimized.

Show comment
Hide comment
@zpao

zpao Mar 27, 2015

Member

@marocchino awesome! We'll be better with actually merging the PRs moving forward :)

Member

zpao commented Mar 27, 2015

@marocchino awesome! We'll be better with actually merging the PRs moving forward :)

@marocchino marocchino deleted the reactkr:translate-ko-release branch Mar 27, 2015

@toughrogrammer

This comment has been minimized.

Show comment
Hide comment

👍

zpao added a commit that referenced this pull request Apr 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment