New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop transforming class -> className #328

Merged
merged 1 commit into from Sep 10, 2013

Conversation

Projects
None yet
5 participants
@zpao
Member

zpao commented Sep 9, 2013

It has been decided.

Going to sync the timing of this with all the internal things we need to fix, but getting it out there.

  • update transform
  • update examples
  • update tests
  • add warning for class and for to suggest className and htmlFor
Stop transforming class -> className
Update the broken examples too (`git grep class=`)
'class': 'className',
cxName: 'className'
};
var JSX_ATTRIBUTE_TRANSFORMS = {
cxName: function(attr) {

This comment has been minimized.

@zpao

zpao Sep 9, 2013

Member

We already killed this internally too, so I'll end up getting rid of it at the same time.

@zpao

zpao Sep 9, 2013

Member

We already killed this internally too, so I'll end up getting rid of it at the same time.

@jeffmo

This comment has been minimized.

Show comment
Hide comment
@jeffmo

jeffmo Sep 10, 2013

Member

I wish github had like buttons...

Member

jeffmo commented Sep 10, 2013

I wish github had like buttons...

jeffmo pushed a commit that referenced this pull request Sep 10, 2013

Jeff Morrison Jeff Morrison
Merge pull request #328 from zpao/no-transform-class
Stop transforming class -> className

@jeffmo jeffmo merged commit 7a6a508 into facebook:master Sep 10, 2013

1 check passed

default The Travis CI build passed
Details

@chenglou chenglou referenced this pull request Sep 12, 2013

Closed

className vs class #346

@niclashoyer niclashoyer referenced this pull request Dec 7, 2013

Closed

class → className #16

@mhlmhl

This comment has been minimized.

Show comment
Hide comment
@mhlmhl

mhlmhl Mar 3, 2016

Would it be unreasonable to update the documentation examples to use "className" instead of "class". One would think that copying the examples would get you working code ... but no.

mhlmhl commented Mar 3, 2016

Would it be unreasonable to update the documentation examples to use "className" instead of "class". One would think that copying the examples would get you working code ... but no.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Mar 3, 2016

@zpao updated the pull request.

facebook-github-bot commented Mar 3, 2016

@zpao updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment