Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extraction of primatives from ReactFragment.extract* #3334

Closed
wants to merge 2 commits into from
Closed

Allow extraction of primatives from ReactFragment.extract* #3334

wants to merge 2 commits into from

Conversation

zpao
Copy link
Member

@zpao zpao commented Mar 6, 2015

We already allow it but this ensures that we allow it in __DEV__ too.

@zpao zpao force-pushed the fragment-extract-primatives branch from 57bddc9 to 5b0efd3 Compare March 6, 2015 01:59
@sebmarkbage
Copy link
Collaborator

This should be annotated with the type object (non-null) and we should simply always do type checks before calling it.

@sebmarkbage sebmarkbage closed this Mar 9, 2015
@zpao zpao deleted the fragment-extract-primatives branch April 16, 2015 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Resolution: Wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zpao @sebmarkbage