Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Dec 2, 2025

Local yarn build always built experimental and stable locally. However, that's not always necessary. E.g. yarn build-for-devtools only needs experimental but you had to wait for stable to finish as well.

CI should be unaffected. --release-channel was already supported with --ci.

@eps1lon eps1lon requested review from hoxyq and poteto December 2, 2025 19:50
@meta-cla meta-cla bot added the CLA Signed label Dec 2, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Dec 2, 2025
@react-sizebot
Copy link

Comparing: 09f0569...f8383be

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.36 kB 608.36 kB = 107.68 kB 107.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 667.47 kB 667.47 kB = 117.57 kB 117.57 kB
facebook-www/ReactDOM-prod.classic.js = 693.67 kB 693.67 kB = 122.07 kB 122.06 kB
facebook-www/ReactDOM-prod.modern.js = 684.10 kB 684.10 kB = 120.45 kB 120.45 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against f8383be

@eps1lon eps1lon marked this pull request as ready for review December 2, 2025 20:09
Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update any of the GH action workflow files too?

@eps1lon
Copy link
Collaborator Author

eps1lon commented Dec 2, 2025

They should be unaffected since they run with --ci which doesn't enter the changed codepath:

- run: yarn build --index=${{ matrix.worker_id }} --total=25 --r=${{ matrix.release_channel }} --ci

Other invocations of yarn build in the repo don't use --release-channel, -r, --release_channel, or --release_channel

Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for confirming!

@eps1lon eps1lon merged commit 36df5e8 into facebook:main Dec 2, 2025
247 checks passed
@eps1lon eps1lon deleted the sebbie/release-single branch December 2, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants