Skip to content

[flow] Upgrade from 0.280 -> 0.281 #35330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
poteto wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[flow] Upgrade from 0.280 -> 0.281 #35330

poteto wants to merge 2 commits into from
+3,142 −4,762

Conversation

@poteto
Copy link
Member

@poteto poteto commented Dec 8, 2025 •
edited
Loading

Major changes in Flow 0.281:

  • $FlowFixMe comments now require explicit error codes (e.g., $FlowFixMe[incompatible-type])
  • Changed all bare $FlowFixMe to include appropriate error codes
  • Changed $FlowIgnore to $FlowFixMe where needed
  • Fixed stream types to have cancel() return Promise instead of void
  • Added pseudoElement property to KeyframeEffect type
  • Added suppressions for Proxy handler variance issues
  • Fixed various type errors across the codebase

Stack created with Sapling. Best reviewed with ReviewStack.

This was referenced Dec 8, 2025
Open
Open
Open
Open
@meta-cla meta-cla bot added the CLA Signed label Dec 8, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Dec 8, 2025
@poteto poteto mentioned this pull request Dec 8, 2025
Draft
@react-sizebot
Copy link

react-sizebot commented Dec 8, 2025 •
edited
Loading

Comparing: 55480b4...00b49e3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.36 kB 608.36 kB = 107.68 kB 107.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 667.47 kB 667.47 kB = 117.57 kB 117.57 kB
facebook-www/ReactDOM-prod.classic.js = 693.67 kB 693.67 kB = 122.07 kB 122.07 kB
facebook-www/ReactDOM-prod.modern.js = 684.10 kB 684.10 kB = 120.45 kB 120.45 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/esm/react-server-dom-webpack-node-loader.production.js +0.33% 20.07 kB 20.13 kB +0.59% 4.93 kB 4.96 kB
oss-stable-semver/react-server-dom-webpack/esm/react-server-dom-webpack-node-loader.production.js +0.33% 20.07 kB 20.13 kB +0.59% 4.93 kB 4.96 kB
oss-stable/react-server-dom-webpack/esm/react-server-dom-webpack-node-loader.production.js +0.33% 20.07 kB 20.13 kB +0.59% 4.93 kB 4.96 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.25% 96.61 kB 96.85 kB +0.15% 19.92 kB 19.95 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.25% 96.61 kB 96.85 kB +0.15% 19.92 kB 19.95 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.25% 96.61 kB 96.85 kB +0.15% 19.92 kB 19.95 kB

Generated by 🚫 dangerJS against 00b49e3

poteto added 2 commits December 8, 2025 15:27
@poteto
[flow] Upgrade from 0.279 -> 0.280
76dc3c0 
Flow 0.280 introduced stricter type checking for `incompatible-type` errors,
requiring additional $FlowFixMe suppressions alongside existing ones. Changes:

- Made `QueuingStrategy` properties optional in streams.js
- Made all properties optional in Web Animations API types (EffectTiming,
  KeyframeAnimationOptions, etc.)
- Added `$FlowFixMe[incompatible-type]` alongside existing suppressions in
  multiple files where Flow now reports additional type mismatches
@poteto
[flow] Upgrade from 0.280 -> 0.281
00b49e3 
Major changes in Flow 0.281:
- $FlowFixMe comments now require explicit error codes (e.g., $FlowFixMe[incompatible-type])
- Changed all bare $FlowFixMe to include appropriate error codes
- Changed $FlowIgnore to $FlowFixMe where needed
- Fixed stream types to have cancel() return Promise<void> instead of void
- Added pseudoElement property to KeyframeEffect type
- Added suppressions for Proxy handler variance issues
- Fixed various type errors across the codebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@poteto @react-sizebot