diff --git a/packages/react-devtools-shared/src/__tests__/profilingCommitTreeBuilder-test.js b/packages/react-devtools-shared/src/__tests__/profilingCommitTreeBuilder-test.js index 968fda10dab5..f08629dd05df 100644 --- a/packages/react-devtools-shared/src/__tests__/profilingCommitTreeBuilder-test.js +++ b/packages/react-devtools-shared/src/__tests__/profilingCommitTreeBuilder-test.js @@ -9,10 +9,7 @@ import type Store from 'react-devtools-shared/src/devtools/store'; -import { - getLegacyRenderImplementation, - getModernRenderImplementation, -} from './utils'; +import {getVersionedRenderImplementation} from './utils'; describe('commit tree', () => { let React = require('react'); @@ -32,12 +29,10 @@ describe('commit tree', () => { Scheduler = require('scheduler'); }); - const {render: legacyRender} = getLegacyRenderImplementation(); - const {render: modernRender} = getModernRenderImplementation(); + const {render} = getVersionedRenderImplementation(); // @reactVersion >= 16.9 - // @reactVersion <= 18.2 - it('should be able to rebuild the store tree for each commit (legacy render)', () => { + it('should be able to rebuild the store tree for each commit', () => { const Parent = ({count}) => { Scheduler.unstable_advanceTime(10); return new Array(count) @@ -50,13 +45,13 @@ describe('commit tree', () => { }); utils.act(() => store.profilerStore.startProfiling()); - utils.act(() => legacyRender()); + utils.act(() => render()); expect(store).toMatchInlineSnapshot(` [root] ▾ [Memo] `); - utils.act(() => legacyRender()); + utils.act(() => render()); expect(store).toMatchInlineSnapshot(` [root] ▾ @@ -64,73 +59,14 @@ describe('commit tree', () => { [Memo] [Memo] `); - utils.act(() => legacyRender()); + utils.act(() => render()); expect(store).toMatchInlineSnapshot(` [root] ▾ [Memo] [Memo] `); - utils.act(() => legacyRender()); - expect(store).toMatchInlineSnapshot(` - [root] - - `); - utils.act(() => store.profilerStore.stopProfiling()); - - const rootID = store.roots[0]; - const commitTrees = []; - for (let commitIndex = 0; commitIndex < 4; commitIndex++) { - commitTrees.push( - store.profilerStore.profilingCache.getCommitTree({ - commitIndex, - rootID, - }), - ); - } - - expect(commitTrees[0].nodes.size).toBe(3); // + + - expect(commitTrees[1].nodes.size).toBe(5); // + + x 3 - expect(commitTrees[2].nodes.size).toBe(4); // + + x 2 - expect(commitTrees[3].nodes.size).toBe(2); // + - }); - - // @reactVersion >= 18 - it('should be able to rebuild the store tree for each commit (createRoot)', () => { - const Parent = ({count}) => { - Scheduler.unstable_advanceTime(10); - return new Array(count) - .fill(true) - .map((_, index) => ); - }; - const Child = React.memo(function Child() { - Scheduler.unstable_advanceTime(2); - return null; - }); - - utils.act(() => store.profilerStore.startProfiling()); - utils.act(() => modernRender()); - expect(store).toMatchInlineSnapshot(` - [root] - ▾ - [Memo] - `); - utils.act(() => modernRender()); - expect(store).toMatchInlineSnapshot(` - [root] - ▾ - [Memo] - [Memo] - [Memo] - `); - utils.act(() => modernRender()); - expect(store).toMatchInlineSnapshot(` - [root] - ▾ - [Memo] - [Memo] - `); - utils.act(() => modernRender()); + utils.act(() => render()); expect(store).toMatchInlineSnapshot(` [root] @@ -179,10 +115,9 @@ describe('commit tree', () => { }); // @reactVersion >= 16.9 - // @reactVersion <= 18.2 - it('should support Lazy components (legacy render)', async () => { + it('should support Lazy components', async () => { utils.act(() => store.profilerStore.startProfiling()); - utils.act(() => legacyRender()); + utils.act(() => render()); await Promise.resolve(); expect(store).toMatchInlineSnapshot(` [root] @@ -191,7 +126,7 @@ describe('commit tree', () => { [suspense-root] rects={null} `); - utils.act(() => legacyRender()); + utils.act(() => render()); expect(store).toMatchInlineSnapshot(` [root] ▾ @@ -200,7 +135,7 @@ describe('commit tree', () => { [suspense-root] rects={null} `); - utils.act(() => legacyRender()); + utils.act(() => render()); expect(store).toMatchInlineSnapshot(` [root] @@ -223,55 +158,10 @@ describe('commit tree', () => { expect(commitTrees[2].nodes.size).toBe(2); // + }); - // @reactVersion >= 18.0 - it('should support Lazy components (createRoot)', async () => { - utils.act(() => store.profilerStore.startProfiling()); - utils.act(() => modernRender()); - await Promise.resolve(); - expect(store).toMatchInlineSnapshot(` - [root] - ▾ - - [suspense-root] rects={null} - - `); - utils.act(() => modernRender()); - expect(store).toMatchInlineSnapshot(` - [root] - ▾ - ▾ - - [suspense-root] rects={null} - - `); - utils.act(() => modernRender()); - expect(store).toMatchInlineSnapshot(` - [root] - - `); - utils.act(() => store.profilerStore.stopProfiling()); - - const rootID = store.roots[0]; - const commitTrees = []; - for (let commitIndex = 0; commitIndex < 3; commitIndex++) { - commitTrees.push( - store.profilerStore.profilingCache.getCommitTree({ - commitIndex, - rootID, - }), - ); - } - - expect(commitTrees[0].nodes.size).toBe(3); // + + - expect(commitTrees[1].nodes.size).toBe(4); // + + + - expect(commitTrees[2].nodes.size).toBe(2); // + - }); - // @reactVersion >= 16.9 - // @reactVersion <= 18.2 - it('should support Lazy components that are unmounted before resolving (legacy render)', async () => { + it('should support Lazy components that are unmounted before resolving', async () => { utils.act(() => store.profilerStore.startProfiling()); - utils.act(() => legacyRender()); + utils.act(() => render()); expect(store).toMatchInlineSnapshot(` [root] ▾ @@ -279,7 +169,7 @@ describe('commit tree', () => { [suspense-root] rects={null} `); - utils.act(() => legacyRender()); + utils.act(() => render()); expect(store).toMatchInlineSnapshot(` [root] @@ -300,38 +190,5 @@ describe('commit tree', () => { expect(commitTrees[0].nodes.size).toBe(3); expect(commitTrees[1].nodes.size).toBe(2); // + }); - - // @reactVersion >= 18.0 - it('should support Lazy components that are unmounted before resolving (createRoot)', async () => { - utils.act(() => store.profilerStore.startProfiling()); - utils.act(() => modernRender()); - expect(store).toMatchInlineSnapshot(` - [root] - ▾ - - [suspense-root] rects={null} - - `); - utils.act(() => modernRender()); - expect(store).toMatchInlineSnapshot(` - [root] - - `); - utils.act(() => store.profilerStore.stopProfiling()); - - const rootID = store.roots[0]; - const commitTrees = []; - for (let commitIndex = 0; commitIndex < 2; commitIndex++) { - commitTrees.push( - store.profilerStore.profilingCache.getCommitTree({ - commitIndex, - rootID, - }), - ); - } - - expect(commitTrees[0].nodes.size).toBe(3); // + + - expect(commitTrees[1].nodes.size).toBe(2); // + - }); }); });