New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the animation name appear in the ReactCSSTransitionGroupChild warning #4480

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@slorber
Contributor

slorber commented Jul 24, 2015

This is useful because otherwise when using many different animations we don't always know which one is responsible for the warning

Make the animation name appear in the ReactCSSTransitionGroupChild wa…
…rning

This is useful because otherwise when using many different animations we don't always know which one is responsible for the warning
@jimfb

This comment has been minimized.

Contributor

jimfb commented Jul 24, 2015

For reference, fixes #4465

@berkerpeksag

This comment has been minimized.

berkerpeksag commented Sep 30, 2015

The code modified in this PR has been removed by ea827eb#diff-a0fc1c23053b3bb4b32e9df5735574e1L34 and wording of the new warning looks better to me: ea827eb#diff-4e8ac9785f6a45d42789a3d154bc5b52R36

So I think both this PR and #4465 can be closed now.

@zpao

This comment has been minimized.

Member

zpao commented Sep 30, 2015

Thanks for bringing it up @berkerpeksag!

@zpao zpao closed this Sep 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment