Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose component instance in shallow rendering #4918

Merged
merged 1 commit into from Oct 7, 2015

Conversation

Projects
None yet
5 participants
@glenjamin
Copy link
Contributor

commented Sep 20, 2015

Fixes #4056

@koba04

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2015

What is the reason for exposing as a new API?
It seems to be better to return by ReactShallowRenderer.render because of consistency between ReadDOM.render.

@glenjamin

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2015

Mostly for "consistency" with the other way of getting info out of a shallow render: getRenderOutput()

@sebmarkbage sebmarkbage added this to the 0.15 milestone Oct 6, 2015

sophiebits added a commit that referenced this pull request Oct 7, 2015

Merge pull request #4918 from glenjamin/shallow-getinstance
Expose component instance in shallow rendering

@sophiebits sophiebits merged commit 8ebbb78 into facebook:master Oct 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.