From 2b6360147262b3b81c49ff5ebe6d851bde8a622d Mon Sep 17 00:00:00 2001 From: Ben Alpert Date: Wed, 30 Sep 2015 16:53:47 -0700 Subject: [PATCH] Don't throw for onClick={false} in initial render I accidentally regressed this in #3246. Now this matches what we already checked for updates. --- src/renderers/dom/shared/ReactDOMComponent.js | 4 +++- src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/renderers/dom/shared/ReactDOMComponent.js b/src/renderers/dom/shared/ReactDOMComponent.js index 5114182919491..ff1321851a5c9 100644 --- a/src/renderers/dom/shared/ReactDOMComponent.js +++ b/src/renderers/dom/shared/ReactDOMComponent.js @@ -656,7 +656,9 @@ ReactDOMComponent.Mixin = { continue; } if (registrationNameModules.hasOwnProperty(propKey)) { - enqueuePutListener(this._rootNodeID, propKey, propValue, transaction); + if (propValue) { + enqueuePutListener(this._rootNodeID, propKey, propValue, transaction); + } } else { if (propKey === STYLE) { if (propValue) { diff --git a/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js b/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js index 22b10f663d72a..992a0abe00675 100644 --- a/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js +++ b/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js @@ -630,6 +630,10 @@ describe('ReactDOMComponent', function() { SimpleEventPlugin.willDeleteListener = mocks.getMockFunction(); var container = document.createElement('div'); + ReactDOM.render(
, container); + expect(SimpleEventPlugin.didPutListener.mock.calls.length).toBe(0); + expect(SimpleEventPlugin.willDeleteListener.mock.calls.length).toBe(0); + ReactDOM.render(
, container); expect(SimpleEventPlugin.didPutListener.mock.calls.length).toBe(0); expect(SimpleEventPlugin.willDeleteListener.mock.calls.length).toBe(0);