Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update enqueueCallback invariant to more specifically denote type of passed callback #5193

Merged
merged 1 commit into from Oct 16, 2015

Conversation

Projects
None yet
3 participants
@conorhastings
Copy link
Contributor

commented Oct 16, 2015

closes #5172

@conorhastings conorhastings force-pushed the conorhastings:enqueue-callback-error branch 2 times, most recently from 7840d2f to 97abe0c Oct 16, 2015

@facebook-github-bot

This comment has been minimized.

Copy link

commented Oct 16, 2015

@conorhastings updated the pull request.

@jimfb

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2015

Thanks @conorhastings, this looks great!

In javascript most things are objects (so this protects against string and number but not much else). It probably makes sense to put the keys in parenthesis. So the message becomes: ...with a callback of type object (keys: foo, bar, noise). If you want to be fancy, we wouldn't print the keys if there are none or if there are more than 20 of them.

@conorhastings conorhastings force-pushed the conorhastings:enqueue-callback-error branch from 97abe0c to ba24ee5 Oct 16, 2015

@conorhastings

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2015

@jimfb updated, do you mean something like this?

@conorhastings conorhastings force-pushed the conorhastings:enqueue-callback-error branch from ba24ee5 to b5b3d4d Oct 16, 2015

@facebook-github-bot

This comment has been minimized.

Copy link

commented Oct 16, 2015

@conorhastings updated the pull request.

@conorhastings conorhastings force-pushed the conorhastings:enqueue-callback-error branch from b5b3d4d to ca95660 Oct 16, 2015

@facebook-github-bot

This comment has been minimized.

Copy link

commented Oct 16, 2015

@conorhastings updated the pull request.

@conorhastings conorhastings force-pushed the conorhastings:enqueue-callback-error branch from ca95660 to 20ec78d Oct 16, 2015

@facebook-github-bot

This comment has been minimized.

Copy link

commented Oct 16, 2015

@conorhastings updated the pull request.

@jimfb

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2015

@conorhastings Yep, that looks great! Thanks!

jimfb added a commit that referenced this pull request Oct 16, 2015

Merge pull request #5193 from conorhastings/enqueue-callback-error
update enqueueCallback invariant to more specifically denote type of passed callback

@jimfb jimfb merged commit 0fc8f6a into facebook:master Oct 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@conorhastings conorhastings deleted the conorhastings:enqueue-callback-error branch Oct 16, 2015

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.