From f7816cdbfe0ef38ed43f4354fd6d7d53c2f7efef Mon Sep 17 00:00:00 2001 From: Ben Alpert Date: Fri, 16 Oct 2015 11:36:16 -0700 Subject: [PATCH] Fix buggy DOM nesting warning for text components cf. #5071 --- src/renderers/dom/shared/ReactDOMTextComponent.js | 2 +- .../dom/shared/__tests__/ReactDOMComponent-test.js | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/renderers/dom/shared/ReactDOMTextComponent.js b/src/renderers/dom/shared/ReactDOMTextComponent.js index ded6a67381d9..39ad8a13cdd4 100644 --- a/src/renderers/dom/shared/ReactDOMTextComponent.js +++ b/src/renderers/dom/shared/ReactDOMTextComponent.js @@ -93,7 +93,7 @@ assign(ReactDOMTextComponent.prototype, { if (parentInfo) { // parentInfo should always be present except for the top-level // component when server rendering - validateDOMNesting(this._tag, this, parentInfo); + validateDOMNesting('span', this, parentInfo); } } diff --git a/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js b/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js index 31491eaab805..6604bda7268f 100644 --- a/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js +++ b/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js @@ -926,17 +926,21 @@ describe('ReactDOMComponent', function() { }); var Foo = React.createClass({ render: function() { - return
; + return
; }, }); ReactTestUtils.renderIntoDocument(); - expect(console.error.calls.length).toBe(1); + expect(console.error.calls.length).toBe(2); expect(console.error.argsForCall[0][0]).toBe( 'Warning: validateDOMNesting(...): cannot appear as a child of ' + '. See Foo > table > Row > tr. Add a to your code to ' + 'match the DOM tree generated by the browser.' ); + expect(console.error.argsForCall[1][0]).toBe( + 'Warning: validateDOMNesting(...): cannot appear as a child ' + + 'of
. See Foo > table > span.' + ); }); it('gives useful context in warnings', () => {