Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow numbers after `data-` in custom attributes fixes #2329 #5216
Well, while we're at it: it's not just numbers. If this gets fixed, then it should not just add another special case but allow all valid attributes.
As I said in #2329
GH Review: review-needed
GH Review: needs-revision
Nov 10, 2015
The code points U+10000 and beyond are represented in UCS-2 as two Unicode characters:
Ugg, this is why I wish we didn't have to do our own validation.
Ok, sounds to me like the next step is to write two unit tests (one for a div, one for a custom-component) which performs initial render and an update render, verify no warnings are emitted. That will likely include expanding the whitelist that @spicyj and @zpao mentioned.
After patching the function I discovered that Chrome, Safari and Firefox don't like
Simple code to reproduce: