Add support for SVG marker element #5398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including marker-specific attributes (markerUnits, refX, refY, markerWidth, markerHeight, orient) and an attribute applicaple on path and basic shapes (marker).
Author
|
I am not sure whether it makes sense to update documentation (those docs/docs/ref-04-tags-and-attributes*.md files). Please let me know and I'll fix it if needed. |
Author
|
Closing as per #1657 comments about finding more sustainable solution. |
Collaborator
|
Should be fixed by #5714. Can you please verify with master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including marker-specific attributes (markerUnits, refX, refY, markerWidth, markerHeight, orient) and an attribute applicaple on path and basic shapes (marker).
There is a slight semantic issue regarding
orient. It does not map directly to any DOM property. There isorientattribute butorientTypeandorientAngleproperties. However, orient property as defined here in React hasMUST_USE_ATTRIBUTEflag so it should not be a problem.This is part of umbrella issue #1657.