-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use comment nodes for empty components #5451
Conversation
This makes more sense and avoids DOM nesting problems. ![image](https://cloud.githubusercontent.com/assets/6820/11098713/952348ca-885b-11e5-9757-e4a76467b0b8.png) (ReactSimpleEmptyComponent isn't used here but React Native can use it as it currently does.)
Only reference I can find is #4550 which shouldn't actually be an issue because we work around it in our |
👍 excellent |
With unencrypted HTTP, you'll need to set a |
I thought Knockout is a client-side library only? |
Yup, though Knockout bindings are just attributes/comments in the HTML, so it was common to just render the initial page containing all the knockout-y bits with whatever server-side templating language you were using, then call |
Got it – thanks for the explanation! I don't think this will be an issue for us. |
* LICENSE file in the root directory of this source tree. An additional grant | ||
* of patent rights can be found in the PATENTS file in the same directory. | ||
* | ||
* @providesModule ReactSimpleEmptyComponent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't use this anywhere… is the thinking that this would be used in RN?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. (I even mentioned that in my PR description. ;))
Use comment nodes for empty components
Interesting! Would really like to use this, but it looks like this code hasn't been released yet. Any idea why this will be released? |
@martijnrusschen This will be released in v15, coming soon. |
👍 |
Should this mean that React can render |
@alxndr That's unrelated, sorry. |
This makes more sense and avoids DOM nesting problems.
(ReactSimpleEmptyComponent isn't used here but React Native can use it as it currently does, with View.)