From 9937f0c8bd9fcb4b7424458c1ae5670a7670fb85 Mon Sep 17 00:00:00 2001
From: Ben Alpert <spicyjalapeno@gmail.com>
Date: Tue, 19 Nov 2013 23:43:22 -0800
Subject: [PATCH] Make ReactEventTopLevelCallback-test pass

This module-level mock() seems to have been interfering with other tests (26 specs failing). We don't have any other tests that do a module-level mock() so I'm going to assume it isn't supported in the open-source test runner right now. I changed it so only ReactEventEmitter.handleTopLevel is mocked; doing so made ReactEventEmitter complain that TopLevelCallbackCreator wasn't defined so I switched the ReactMount references to use React directly so that ReactDefaultInjection would kick in properly.

With this, all the tests pass.
---
 .../ReactEventTopLevelCallback-test.js        | 29 +++++++++++--------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/src/core/__tests__/ReactEventTopLevelCallback-test.js b/src/core/__tests__/ReactEventTopLevelCallback-test.js
index 3b63e1513188d..8252263e2839b 100644
--- a/src/core/__tests__/ReactEventTopLevelCallback-test.js
+++ b/src/core/__tests__/ReactEventTopLevelCallback-test.js
@@ -22,23 +22,28 @@ require('mock-modules')
   .dontMock('ReactEventTopLevelCallback')
   .dontMock('ReactMount')
   .dontMock('ReactInstanceHandles')
-  .dontMock('ReactDOM')
-  .mock('ReactEventEmitter');
+  .dontMock('ReactDOM');
 
 var EVENT_TARGET_PARAM = 1;
 
 describe('ReactEventTopLevelCallback', function() {
+  var mocks;
+
+  var React;
   var ReactEventTopLevelCallback;
-  var ReactMount;
   var ReactDOM;
-  var ReactEventEmitter; // mocked
+  var ReactEventEmitter;
 
   beforeEach(function() {
     require('mock-modules').dumpCache();
+    mocks = require('mocks');
+
+    React = require('React');
     ReactEventTopLevelCallback = require('ReactEventTopLevelCallback');
-    ReactMount = require('ReactMount');
     ReactDOM = require('ReactDOM');
-    ReactEventEmitter = require('ReactEventEmitter'); // mocked
+    ReactEventEmitter = require('ReactEventEmitter');
+
+    ReactEventEmitter.handleTopLevel = mocks.getMockFunction();
   });
 
   describe('Propagation', function() {
@@ -47,8 +52,8 @@ describe('ReactEventTopLevelCallback', function() {
       var childControl = ReactDOM.div({}, 'Child');
       var parentContainer = document.createElement('div');
       var parentControl = ReactDOM.div({}, 'Parent');
-      ReactMount.renderComponent(childControl, childContainer);
-      ReactMount.renderComponent(parentControl, parentContainer);
+      React.renderComponent(childControl, childContainer);
+      React.renderComponent(parentControl, parentContainer);
       parentControl.getDOMNode().appendChild(childContainer);
 
       var callback = ReactEventTopLevelCallback.createTopLevelCallback('test');
@@ -69,9 +74,9 @@ describe('ReactEventTopLevelCallback', function() {
       var parentControl = ReactDOM.div({}, 'Parent');
       var grandParentContainer = document.createElement('div');
       var grandParentControl = ReactDOM.div({}, 'Parent');
-      ReactMount.renderComponent(childControl, childContainer);
-      ReactMount.renderComponent(parentControl, parentContainer);
-      ReactMount.renderComponent(grandParentControl, grandParentContainer);
+      React.renderComponent(childControl, childContainer);
+      React.renderComponent(parentControl, parentContainer);
+      React.renderComponent(grandParentControl, grandParentContainer);
       parentControl.getDOMNode().appendChild(childContainer);
       grandParentControl.getDOMNode().appendChild(parentContainer);
 
@@ -95,7 +100,7 @@ describe('ReactEventTopLevelCallback', function() {
     var control = ReactDOM.div({}, [
       ReactDOM.div({id: 'outer'}, inner)
     ]);
-    ReactMount.renderComponent(control, container);
+    React.renderComponent(control, container);
 
     var callback = ReactEventTopLevelCallback.createTopLevelCallback('test');
     callback({