Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DOM functions from top-level isomorphic API #5832

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Projects
None yet
3 participants
@jimfb
Copy link
Contributor

commented Jan 12, 2016

Remove DOM functions from top-level isomorphic API. I have a couple diffs internally that make this safe. When they land, this should be good-to-go.

@sebmarkbage sebmarkbage referenced this pull request Jan 12, 2016

Closed

Umbrella 15.0 #4600

5 of 7 tasks complete

@jimfb jimfb force-pushed the jimfb:cleanup-top-level-dom-api branch from 001b565 to 2e1fb4b Jan 12, 2016

@zpao

This comment has been minimized.

Copy link
Member

commented Jan 12, 2016

Can you do a quick check to confirm nobody internally re-added calls before merging?

@jimfb

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2016

@zpao Yeah. I have a few 0.15 diffs, so my plan was to just do a React sync once everything lands internally+github, and I'll verify for any stragglers as part of the sync (there should only be one or two at that point).

jimfb added a commit that referenced this pull request Jan 13, 2016

Merge pull request #5832 from jimfb/cleanup-top-level-dom-api
Remove DOM functions from top-level isomorphic API

@jimfb jimfb merged commit fcc63e1 into facebook:master Jan 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.