Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap insertBefore in Windows 8 apps #6063

Merged
merged 1 commit into from Feb 18, 2016

Conversation

Projects
None yet
3 participants
@Andrew8xx8
Copy link
Contributor

commented Feb 18, 2016

React does not work correctly on Windows 8 app. This platform has security restrictions and in some cases it throws this error:

0x800c001c - JavaScript runtime error: Unable to add dynamic content. A script attempted to inject dynamic content, or elements previously modified dynamically, that might be unsafe. For example, using the innerHTML property to add script or malformed HTML will generate this exception. Use the toStaticHTML method to filter dynamic content, or explicitly create elements and attributes with a method such as createElement. For more information, see http://go.microsoft.com/fwlink/?LinkID=247104.

The bug is related to #441 and have a similar reason but with insertBefore call. It can be fixed in the same way.

@jimfb

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2016

Sure, looks legit, thanks!

jimfb added a commit that referenced this pull request Feb 18, 2016

Merge pull request #6063 from Andrew8xx8/master
Wrap insertBefore in Windows 8 apps

@jimfb jimfb merged commit 5879c9e into facebook:master Feb 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.