Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppressContentEditableWarning #6112

Merged
merged 1 commit into from Feb 24, 2016

Conversation

Projects
None yet
4 participants
@mxstbr
Copy link
Contributor

commented Feb 24, 2016

I went with suppressContentEditableWarning for now, but that's a quick change.

See #5837

/cc @jimfb @spicyj

@mxstbr mxstbr force-pushed the mxstbr:surpressContentEditableWarning branch from d5699e2 to 35484e5 Feb 24, 2016

@sophiebits

This comment has been minimized.

Copy link
Collaborator

commented Feb 24, 2016

suppress, not sur

@mxstbr mxstbr force-pushed the mxstbr:surpressContentEditableWarning branch from 35484e5 to f7276b3 Feb 24, 2016

@mxstbr mxstbr changed the title Add surpressContentEditableWarning Add suppressContentEditableWarning Feb 24, 2016

@mxstbr

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2016

The one thing I could have gotten wrong... Fixed, thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Feb 24, 2016

@mxstbr updated the pull request.

@jimfb

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2016

Looks good, thanks @mxstbr!

jimfb added a commit that referenced this pull request Feb 24, 2016

@jimfb jimfb merged commit 7a3009c into facebook:master Feb 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mxstbr mxstbr deleted the mxstbr:surpressContentEditableWarning branch Feb 24, 2016

@mxstbr

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2016

Awesome!

mxstbr added a commit to mxstbr/draft-js that referenced this pull request Feb 24, 2016

Suppress contentEditable warning
This will come into effect with the 15.0 release of React, see facebook/react#6112

Fixes facebook#53

flarnie added a commit to flarnie/draft-js that referenced this pull request Sep 20, 2016

Update docs to remove 'React ContentEditable Warning' issue
The issue with 'React ContentEditable Warning' was resolved when React
added the 'suppressContentEditableWarning' option[1] and then we used it
in Draft.js[2]. This doesn't need to be in the docs any more.

[1]: facebook/react#6112
[2]: facebook#98

@gaspard gaspard referenced this pull request Mar 2, 2017

Merged

Add suppressContentEditableWarning to react #14955

10 of 10 tasks complete

@nss213 nss213 referenced this pull request Mar 31, 2017

Closed

react warning #86

ouchxp added a commit to ouchxp/draft-js that referenced this pull request Apr 7, 2017

Update docs to remove 'React ContentEditable Warning' issue
The issue with 'React ContentEditable Warning' was resolved when React
added the 'suppressContentEditableWarning' option[1] and then we used it
in Draft.js[2]. This doesn't need to be in the docs any more.

[1]: facebook/react#6112
[2]: facebook#98

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.