Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #6114 - Calling setState inside getChildContext should warn #6121
1 similar comment
This was referenced
Feb 28, 2016
I am failing a test locally not sure why it isn't failing in travis. Is that kinda worrying?
I looked into the failing unit test, it looks like a valid failure caused by this change (ie. needs to be fixed before we can merge). That test is not invoking
I'm not sure why it didn't fail travis (cc @zpao).
referenced this pull request
Mar 3, 2016
Wow I spent so long on this problem. I looked at some awesome code that vslinko wrote to fix this issue and it was so simple, I just did not fully understand the issue I was fixing. I made an early assumption of where the code should go and tried everything to make it work. Sigh. Like trying to stick a square peg in a round hole