Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support standard "cssFloat" css property #6133

Merged
merged 1 commit into from Feb 28, 2016

Conversation

Projects
None yet
3 participants
@stevenvachon
Copy link
Contributor

commented Feb 27, 2016

For tools that compile CSS may have already converted the name.

More info:
https://npmjs.com/camelcase-css
https://npmjs.com/postcss-js

support standard "cssFloat" css property
For tools that compile CSS may have already converted the name.

More info:
https://npmjs.com/camelcase-css
https://npmjs.com/postcss-js
@facebook-github-bot

This comment has been minimized.

Copy link

commented Feb 27, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Feb 27, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@@ -185,7 +185,7 @@ var CSSPropertyOperations = {
styles[styleName],
component
);
if (styleName === 'float') {
if (styleName === 'float' || styleName === 'cssFloat') {
styleName = styleFloatAccessor;
}

This comment has been minimized.

Copy link
@zpao

zpao Feb 27, 2016

Member

We only need to set styleName to cssFloat if it isn't already cssFloat, so this doesn't actually do anything. i appreciate the thought though.

This comment has been minimized.

Copy link
@stevenvachon

stevenvachon Feb 27, 2016

Author Contributor

It sets it to styleFloat in IE8.

@zpao zpao closed this Feb 27, 2016

@zpao

This comment has been minimized.

Copy link
Member

commented Feb 27, 2016

Ah true, that's what I get for trying to review from my phone 😬

@zpao zpao reopened this Feb 27, 2016

@stevenvachon

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2016

:) np

zpao added a commit that referenced this pull request Feb 28, 2016

Merge pull request #6133 from stevenvachon/patch-1
support standard "cssFloat" css property

@zpao zpao merged commit adc9104 into facebook:master Feb 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zpao

This comment has been minimized.

Copy link
Member

commented Feb 28, 2016

Thanks!

@vikfroberg vikfroberg referenced this pull request Dec 22, 2016

Closed

Add support for cssFloat #54

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.