Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added borderImageOutset to unitless CSS properties #6210

Merged
merged 1 commit into from Mar 11, 2016

Conversation

Projects
None yet
3 participants
@weserio
Copy link
Contributor

commented Mar 8, 2016

I found this property and ran into a problem using it as React automatically adds the px unit to it.
According to https://drafts.csswg.org/css-backgrounds-3/#border-image-outset it supports both number and length values.
Always applying px therefore might in that case perhaps return unwanted behavior.

added border-image-outset CSS property to unitless properties
According to
https://drafts.csswg.org/css-backgrounds-3/#border-image-outset it
supports both number and length values.
Always applying ‘px’ might in that case perhaps return unwanted
behavior.
@zpao

This comment has been minimized.

Copy link
Member

commented Mar 8, 2016

Cool, doing a bit of planning so not merging this very second but I think we should get this into 15.

@weserio

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2016

I guess not many people even use this property actually, but as it is not a big deal it would make sense to add it, thank you :)

zpao added a commit that referenced this pull request Mar 11, 2016

Merge pull request #6210 from rofrischmann/unitless-border-image-outset
added borderImageOutset to unitless CSS properties

@zpao zpao merged commit 20e1acb into facebook:master Mar 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.