Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react/addons #6285

Merged
merged 1 commit into from Mar 17, 2016

Conversation

Projects
None yet
4 participants
@gaearon
Copy link
Member

commented Mar 17, 2016

Not sure what the plan is with 15.0 but accessing react/addons in the CommonJS environment has been deprecated since 0.14 betas. This commit removes react/addons entry point.

If the consumer uses CommonJS, they need to switch to using react-addons-<addon name> package as we warned during 0.14. If the consumer uses addons-enabled UMD build, they don’t need to change anything.

Can we get this into v15?

@jimfb

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2016

As long as this won't break the browser-with-addons builds, I'm good with this. 👍

@zpao manages the building/packaging, so it's worth pinging him for a go ahead.

@gaearon

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2016

As far as I can see the UMD addons build uses ReactWithAddons which stays. Only the file that contained the warning is removed, and that one was specifically in the npm React package folder and outside the source directory.

@zpao

This comment has been minimized.

Copy link
Member

commented Mar 17, 2016

I wish we had remembered to do this before rc but that's ok. 👍

gaearon added a commit that referenced this pull request Mar 17, 2016

@gaearon gaearon merged commit 8046cbd into facebook:master Mar 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gaearon gaearon deleted the gaearon:no-addons branch Mar 17, 2016

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.