Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loose-envify instead of envify #6303

Merged
merged 1 commit into from Mar 21, 2016

Conversation

Projects
None yet
3 participants
@qerub
Copy link
Contributor

commented Mar 19, 2016

As per discussion in #6252. This reduces the number of transitive dependencies and decreases the build time (by ~6% on my machine). I've confirmed that the compiled artifacts are identical to those generated by envify.

@@ -2,7 +2,7 @@

'use strict';

var envify = require('envify/custom');
var envify = require('loose-envify/loose-envify');

This comment has been minimized.

Copy link
@zpao

zpao Mar 21, 2016

Member

Can you leave the /custom bit - the API matches envify so we can keep that part the same.

@zpao zpao added this to the 15.0 milestone Mar 21, 2016

Use loose-envify instead of envify
This reduces the number of transitive dependencies and decreases the build time (by ~6% on my machine).

@qerub qerub force-pushed the qerub:use-loose-envify branch from 5210b01 to ecf824c Mar 21, 2016

@facebook-github-bot

This comment has been minimized.

Copy link

commented Mar 21, 2016

@qerub updated the pull request.

@zpao

This comment has been minimized.

Copy link
Member

commented Mar 21, 2016

Thanks!

zpao added a commit that referenced this pull request Mar 21, 2016

Merge pull request #6303 from qerub/use-loose-envify
Use loose-envify instead of envify

@zpao zpao merged commit 40c4635 into facebook:master Mar 21, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.