Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free memory allocated by testElement after usage #6309

Merged
merged 1 commit into from Mar 21, 2016

Conversation

Projects
None yet
3 participants
@victor-homyakov
Copy link
Contributor

commented Mar 21, 2016

IE11 reports testElement as detached DOM node consuming memory. It is captured in closure of setInnerHTML function and could be safely cleared after feature test.

Free memory allocated by testElement after usage
IE11 reports `testElement` as detached DOM node consuming memory. It is captured in closure of `setInnerHTML` function and could be safely cleared after feature test.
@victor-homyakov

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2016

image

@zpao

This comment has been minimized.

Copy link
Member

commented Mar 21, 2016

👍 Nice find, thanks!

zpao added a commit that referenced this pull request Mar 21, 2016

Merge pull request #6309 from victor-homyakov/patch-1
Free memory allocated by testElement after usage

@zpao zpao merged commit 75e4ef1 into facebook:master Mar 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@victor-homyakov victor-homyakov deleted the victor-homyakov:patch-1 branch Mar 21, 2016

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.