-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid "Member not found" error in IE #7411
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
b7e2ea7
to
f72e7f2
Compare
Explanation, discussion, and similar change as facebook#7343 Addresses facebook#7320
f72e7f2
to
9560eda
Compare
Don't mean to bug you guys and apologies in advance if I am, but is there anything I specifically need to do to get this reviewed? |
@g-palmer hey, we appreciate being bugged here and there. It's easy for stuff to fall through the cracks, so thanks for the reminder. This seems like a good and safe change 👍 thanks! |
Would be nice to add an explanatory comment linking to the issue everywhere we do this. |
Sure thing. Would it make sense if I just updated this same branch with the additional comment(s) and opened a new PR? Or do you prefer a new branch as well as a new PR? |
Since this is already merged I think new branch would make more sense. |
Explanation, discussion, and similar change as #7343
Addresses #7320