New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix batchedUpdates return value #7444

Merged
merged 2 commits into from Aug 9, 2016

Conversation

Projects
None yet
4 participants
@ghost

ghost commented Aug 8, 2016

When I used ReactDOM.unstable_batchedUpdates with redux middleware to fix this issue (reduxjs/react-redux#292) it breaks redux middleware return value.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 8, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

ghost commented Aug 8, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Aug 8, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented Aug 8, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Aug 8, 2016

@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits Aug 8, 2016

Member

This seems reasonable, I think. If you add the semicolon we can merge.

In the meantime, you can always work around this with something like

var x;
ReactDOM.unstable_batchedUpdates(function() {
  x = 42;
});
Member

sophiebits commented Aug 8, 2016

This seems reasonable, I think. If you add the semicolon we can merge.

In the meantime, you can always work around this with something like

var x;
ReactDOM.unstable_batchedUpdates(function() {
  x = 42;
});

@ghost ghost added the CLA Signed label Aug 8, 2016

@ghost ghost added the CLA Signed label Aug 9, 2016

@sophiebits sophiebits merged commit 7d57c1f into facebook:master Aug 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits Aug 9, 2016

Member

Thanks!

Member

sophiebits commented Aug 9, 2016

Thanks!

@sophiebits sophiebits added this to the 15-next milestone Aug 9, 2016

@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016

zpao added a commit that referenced this pull request Oct 4, 2016

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v16 #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment