-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix batchedUpdates return value #7444
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@@ -1147,4 +1147,10 @@ describe('ReactUpdates', function() { | |||
ReactDOM.render(<App />, document.createElement('div')); | |||
}); | |||
|
|||
it('unstable_batchedUpdates should return value from a callback', function() { | |||
var result = ReactDOM.unstable_batchedUpdates(function() { | |||
return 42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a semicolon here?
(@zpao don't we lint for semicolons?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, though apparently it's only a warning so didn't fail CI (https://travis-ci.org/facebook/react/jobs/150690962#L285)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't realize we had warnings.
This seems reasonable, I think. If you add the semicolon we can merge. In the meantime, you can always work around this with something like
|
Thanks! |
(cherry picked from commit 7d57c1f)
When I used ReactDOM.unstable_batchedUpdates with redux middleware to fix this issue (reduxjs/react-redux#292) it breaks redux middleware return value.