-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unknown property warning for use of autofocus
#7694
Conversation
* @type {Object} | ||
*/ | ||
getPossibleStandardName: __DEV__ ? {} : null, | ||
getPossibleStandardName: __DEV__ ? {autofocus: 'autoFocus'} : null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a space before the key name and after the value? { autofocus: 'autoFocus' }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Accepted pending the small style change, I'll leave this open for @zpao just in case 😄 |
3ea74ef
to
0f38f8b
Compare
* @type {Object} | ||
*/ | ||
getPossibleStandardName: __DEV__ ? {} : null, | ||
getPossibleStandardName: __DEV__ ? { autofocus: 'autoFocus' } : null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so sorry @hkal, I guess we don't pad inline objects 😭 . You were totally right the first time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries @aweary. I'll change it back.
0f38f8b
to
af45ae6
Compare
Resolves #3248
Resubmission of #6461
cc @aweary @zpao