New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unknown property warning for use of `autofocus` #7694

Merged
merged 1 commit into from Oct 3, 2016

Conversation

Projects
None yet
3 participants
@hkal
Contributor

hkal commented Sep 10, 2016

Resolves #3248
Resubmission of #6461

cc @aweary @zpao

* @type {Object}
*/
getPossibleStandardName: __DEV__ ? {} : null,
getPossibleStandardName: __DEV__ ? {autofocus: 'autoFocus'} : null,

This comment has been minimized.

@aweary

aweary Sep 10, 2016

Member

Can you add a space before the key name and after the value? { autofocus: 'autoFocus' }

@aweary

aweary Sep 10, 2016

Member

Can you add a space before the key name and after the value? { autofocus: 'autoFocus' }

This comment has been minimized.

@hkal

hkal Sep 10, 2016

Contributor

Done.

@hkal

hkal Sep 10, 2016

Contributor

Done.

@aweary

This comment has been minimized.

Show comment
Hide comment
@aweary

aweary Sep 10, 2016

Member

Accepted pending the small style change, I'll leave this open for @zpao just in case 😄

Member

aweary commented Sep 10, 2016

Accepted pending the small style change, I'll leave this open for @zpao just in case 😄

@aweary aweary added the semver-patch label Sep 10, 2016

@aweary aweary added this to the 15-next milestone Sep 10, 2016

@ghost ghost added CLA Signed labels Sep 10, 2016

Show outdated Hide outdated src/renderers/dom/shared/DOMProperty.js
* @type {Object}
*/
getPossibleStandardName: __DEV__ ? {} : null,
getPossibleStandardName: __DEV__ ? { autofocus: 'autoFocus' } : null,

This comment has been minimized.

@aweary

aweary Sep 10, 2016

Member

I'm so sorry @hkal, I guess we don't pad inline objects 😭 . You were totally right the first time.

@aweary

aweary Sep 10, 2016

Member

I'm so sorry @hkal, I guess we don't pad inline objects 😭 . You were totally right the first time.

This comment has been minimized.

@hkal

hkal Sep 11, 2016

Contributor

No worries @aweary. I'll change it back.

@hkal

hkal Sep 11, 2016

Contributor

No worries @aweary. I'll change it back.

@ghost ghost added CLA Signed labels Sep 10, 2016

@ghost ghost added the CLA Signed label Sep 11, 2016

@aweary aweary merged commit f6fdfd1 into facebook:master Oct 3, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 87.306%
Details

@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016

zpao added a commit that referenced this pull request Oct 4, 2016

acusti added a commit to brandcast/react that referenced this pull request Mar 15, 2017

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v16 #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment