Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
React dom invalid aria hook #7744
Currently, React treats all
I've included the list of props from the upcoming ARIA 1.1 Working Draft. I work with one of the editors of this specification. It's currently taken about 3 years to update from 1.0 to 1.1. We should not expect any churn in this list of props in the short- or mid-term future.
@aweary We should at least do this for 15.x. Not sure when 16 will happen but we can make the situation better short-term until we actually solve the attribute whitelist problem. (This is one of the downsides of discussions happening outside GitHub - we talked with Jesse and think we should do this as accessibility is an important thing to focus on)
These were always an afterthought from the get-go and while they probably shouldn't have been, we can and should change that. This is a great way to do it.
What if we made these more first-class citizens so they actually fit in with the other props? It would be hard for the white-list removal situation, but maybe better for React. These attributes don't fit in with the rest at all. They have a dash in them and they aren't camelcase. It's because we just passed anything through (based on the
I guess we could do that separately (we talked about it for
@aweary that's a great discussion, thank you for linking me to it. I understand the hesitation to add yet another whitelist. In this case, we have a finite and known set of attributes; one that is arguably an extension of the DOM spec (or should have been
@zpao You highlight an issue that leads to frustrating variations in the components I encounter:
Yes, I wasn't aware you guys discussed this already
I really like this idea for
I think this is good to go pending the requested change