New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7824 #7832

Merged
merged 1 commit into from Oct 1, 2016

Conversation

Projects
None yet
7 participants
@mnpenner
Contributor

mnpenner commented Sep 29, 2016

Re-submitting this PR since I messed it up. Sorry for the mess.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Sep 29, 2016

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Sep 29, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@syranide

This comment has been minimized.

Show comment
Hide comment
@syranide

syranide Sep 29, 2016

Contributor

👍 cc @jimfb (again :))

Contributor

syranide commented Sep 29, 2016

👍 cc @jimfb (again :))

@jimfb

This comment has been minimized.

Show comment
Hide comment
@jimfb

jimfb Sep 29, 2016

Contributor

For posterity, the repro is:

const React = require('react');
const ReactDOM = require('react-dom');

var Hello = React.createClass({

    getInitialState: function() {
        return {foo: "foo"};
    },

    clickA: function(ev) {
        this.setState({foo: "bar"});
    },


    render: function() {
        return <div>
            <button onClick={this.clickA}>{this.state.foo} <img src="https://s3.amazonaws.com/media-p.slid.es/uploads/alexanderfarennikov/images/1198519/reactjs.png" width="15" height="15" /></button>
        </div>;
    }
});

ReactDOM.render(
    <Hello name="World" />,
    document.getElementById('container')
);
Contributor

jimfb commented Sep 29, 2016

For posterity, the repro is:

const React = require('react');
const ReactDOM = require('react-dom');

var Hello = React.createClass({

    getInitialState: function() {
        return {foo: "foo"};
    },

    clickA: function(ev) {
        this.setState({foo: "bar"});
    },


    render: function() {
        return <div>
            <button onClick={this.clickA}>{this.state.foo} <img src="https://s3.amazonaws.com/media-p.slid.es/uploads/alexanderfarennikov/images/1198519/reactjs.png" width="15" height="15" /></button>
        </div>;
    }
});

ReactDOM.render(
    <Hello name="World" />,
    document.getElementById('container')
);

@jimfb jimfb self-assigned this Sep 29, 2016

@marvinhagemeister

This comment has been minimized.

Show comment
Hide comment
@marvinhagemeister

marvinhagemeister Sep 30, 2016

@mnpenner Thanks for your hard work in tracking this one down!

@mnpenner Thanks for your hard work in tracking this one down!

@jimfb jimfb merged commit dae3043 into facebook:master Oct 1, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 87.858%
Details

@zpao zpao added this to the 15-next milestone Oct 3, 2016

@zpao zpao added the semver-patch label Oct 3, 2016

@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016

zpao added a commit that referenced this pull request Oct 4, 2016

Fixes #7824 (#7832)
(cherry picked from commit dae3043)

acusti added a commit to brandcast/react that referenced this pull request Mar 15, 2017

@blling

This comment has been minimized.

Show comment
Hide comment
@blling

blling Feb 1, 2018

@mnpenner do you use React15 in production, does 15.4.0 support IE8 in your experience?

blling commented Feb 1, 2018

@mnpenner do you use React15 in production, does 15.4.0 support IE8 in your experience?

@blling blling unassigned jimfb Feb 1, 2018

@mnpenner

This comment has been minimized.

Show comment
Hide comment
@mnpenner

mnpenner Feb 1, 2018

Contributor

@blling We're using React 15.6 in production, yes. Soon to upgrade to React 16.2 since we finally dropped IE8.

But in my experience, yes, even 15.6 worked fine with IE8.

We have a ton of polyfills though, so, that may have helped.

Contributor

mnpenner commented Feb 1, 2018

@blling We're using React 15.6 in production, yes. Soon to upgrade to React 16.2 since we finally dropped IE8.

But in my experience, yes, even 15.6 worked fine with IE8.

We have a ton of polyfills though, so, that may have helped.

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v16 #29

@blling

This comment has been minimized.

Show comment
Hide comment
@blling

blling Feb 3, 2018

@mnpenner Thanks.
Could you list the polyfills and package.json configs ( and webpack config if you use webpack ) ? :)

blling commented Feb 3, 2018

@mnpenner Thanks.
Could you list the polyfills and package.json configs ( and webpack config if you use webpack ) ? :)

@mnpenner

This comment has been minimized.

Show comment
Hide comment
@mnpenner

mnpenner Feb 5, 2018

Contributor

@blling Okay...but this is quite specific to our project, and overkill for just about anything else: https://gist.github.com/mnpenner/d09beb0c243311d2f5f512d0899114c0

Contributor

mnpenner commented Feb 5, 2018

@blling Okay...but this is quite specific to our project, and overkill for just about anything else: https://gist.github.com/mnpenner/d09beb0c243311d2f5f512d0899114c0

@blling

This comment has been minimized.

Show comment
Hide comment
@blling

blling Feb 5, 2018

@mnpenner Could you send an email to me with the configs?
I could not open the link for some reason...

blling.fa@gmail.com

blling commented Feb 5, 2018

@mnpenner Could you send an email to me with the configs?
I could not open the link for some reason...

blling.fa@gmail.com

@blling

This comment has been minimized.

Show comment
Hide comment
@blling

blling Feb 28, 2018

cc @mnpenner , are you there? I use webpack1.15.0 and upgrade React to 15.0.0, I get the follow error:

if (IE8_DOM_DEFINE) try {
    return dP(O, P, Attributes);
  } catch (e) { /* empty */ }
// ********************************Throws error here
if ('get' in Attributes || 'set' in Attributes) throw TypeError('Accessors not supported!') 

If i use React 0.14.9 the error is go away, do you know how could i solve the issue?

blling commented Feb 28, 2018

cc @mnpenner , are you there? I use webpack1.15.0 and upgrade React to 15.0.0, I get the follow error:

if (IE8_DOM_DEFINE) try {
    return dP(O, P, Attributes);
  } catch (e) { /* empty */ }
// ********************************Throws error here
if ('get' in Attributes || 'set' in Attributes) throw TypeError('Accessors not supported!') 

If i use React 0.14.9 the error is go away, do you know how could i solve the issue?

@mnpenner

This comment has been minimized.

Show comment
Hide comment
@mnpenner

mnpenner Feb 28, 2018

Contributor

Sorry @blling, I don't know the answer. Try some more polyfills, like core-js/es6, core-js/es5 and core-js/stage/4.

Contributor

mnpenner commented Feb 28, 2018

Sorry @blling, I don't know the answer. Try some more polyfills, like core-js/es6, core-js/es5 and core-js/stage/4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment