Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing variable names #7863

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
4 participants
@koba04
Copy link
Contributor

commented Oct 4, 2016

I think the variables is ReactElement, not ReactComponent.

@gaearon

This comment has been minimized.

Copy link
Member

commented Oct 4, 2016

Oh, totally. Thanks.
I’ll wait for Travis and then merge.

@gaearon gaearon added this to the 15-next milestone Oct 4, 2016

@gaearon gaearon merged commit 30067fa into facebook:master Oct 4, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 87.858%
Details
@koba04

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2016

Thanks!

@koba04 koba04 deleted the koba04:fix-confusing-variable-names branch Oct 4, 2016

@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016

zpao added a commit that referenced this pull request Oct 4, 2016

Fix confusing variable names (#7863)
(cherry picked from commit 30067fa)

acusti added a commit to brandcast/react that referenced this pull request Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.