-
Notifications
You must be signed in to change notification settings - Fork 47.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor precacheChildNodes
slightly
#8018
Conversation
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@ccoffey can you confirm this fix resolves your issue? |
@aweary yep! I work with @ccoffey 😄, and we've verified that this resolves the issue, with our app, and with the repro-case. |
@aweary confirmed, this does resolve the issue I created! |
@spicyj @sebmarkbage does this change seem OK to you? |
Sure, I guess. No guarantee it won't break again later. |
Yeah, I'm not big on including a fix without knowing exactly why its a fix. But I suppose its a harmless change. @eoin can you resolve the merge conflicts? |
This ‘fixes’ a bizarre IE9 script engine issue. #7803
@aweary resolved. |
LGTM, thanks. |
Does anyone have an date for the version which contains this release? |
Ideally we'd like the next patch release to also fix #8392. So if you could help find a solution to it, we could get it out quicker. |
This is now out in 15.4.2. |
This ‘fixes’ a bizarre IE9 script engine issue. facebook#7803
This ‘fixes’ a bizarre IE9 script engine issue, discussed in #7803 (comment).