New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shares debugID information across modules #8097

Merged
merged 1 commit into from Oct 27, 2016

Conversation

Projects
None yet
4 participants
@goatslacker
Contributor

goatslacker commented Oct 25, 2016

Prior to this, React was using a nextDebugID variable that was locally
scoped to both instantiateReactComponent and ReactShallowRenderer.
This caused problems when the debugIDs would collide, the itemMap in
ReactComponentTreeHook would be overwritten and tests would fail
with the message "Expected onBeforeMountComponent() parent and
onSetChildren() to be consistent".

This change shares the debugID with both modules thus preventing any
collisions in the future.

Fixes #7927

Ideally this would be in the next (hotfix?) release of React 15.x as this is preventing us (Airbnb) from upgrading at the moment.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Oct 25, 2016

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@aweary

This comment has been minimized.

Show comment
Hide comment
@aweary

aweary Oct 25, 2016

Member

Thanks for the PR @goatslacker, looks reasonable to me. 15.4.0 is close to release, I'm not sure if it's too late to get this in though.

Member

aweary commented Oct 25, 2016

Thanks for the PR @goatslacker, looks reasonable to me. 15.4.0 is close to release, I'm not sure if it's too late to get this in though.

@goatslacker

This comment has been minimized.

Show comment
Hide comment
@goatslacker

goatslacker Oct 25, 2016

Contributor

Emailed the CLA info.

Contributor

goatslacker commented Oct 25, 2016

Emailed the CLA info.

@gaearon gaearon added this to the 15.4.0 milestone Oct 25, 2016

@@ -0,0 +1,9 @@
'use strict';

This comment has been minimized.

@aweary

aweary Oct 26, 2016

Member

We need to add the header document comment here like the other files (example).

Without the @providesModule comment the haste module system doesn't know where to find this file and tests fail.

@aweary

aweary Oct 26, 2016

Member

We need to add the header document comment here like the other files (example).

Without the @providesModule comment the haste module system doesn't know where to find this file and tests fail.

This comment has been minimized.

@goatslacker

goatslacker Oct 26, 2016

Contributor

Done.

@goatslacker

goatslacker Oct 26, 2016

Contributor

Done.

Shares debugID information across modules
Prior to this, React was using a nextDebugID variable that was locally
scoped to both `instantiateReactComponent` and `ReactShallowRenderer`.
This caused problems when the debugIDs would collide, the `itemMap` in
`ReactComponentTreeHook` would be overwritten and tests would fail
with the message "Expected onBeforeMountComponent() parent and
onSetChildren() to be consistent".

This change shares the debugID with both modules thus preventing any
collisions in the future.

Outdated

@gaearon gaearon merged commit 6eebed0 into facebook:master Oct 27, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 88.496%
Details
@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Oct 27, 2016

Member

Thanks.

Member

gaearon commented Oct 27, 2016

Thanks.

@goatslacker goatslacker deleted the goatslacker:fix-7927 branch Oct 27, 2016

zpao added a commit that referenced this pull request Nov 16, 2016

Shares debugID information across modules (#8097)
Prior to this, React was using a nextDebugID variable that was locally
scoped to both `instantiateReactComponent` and `ReactShallowRenderer`.
This caused problems when the debugIDs would collide, the `itemMap` in
`ReactComponentTreeHook` would be overwritten and tests would fail
with the message "Expected onBeforeMountComponent() parent and
onSetChildren() to be consistent".

This change shares the debugID with both modules thus preventing any
collisions in the future.
(cherry picked from commit 6eebed0)
@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Nov 16, 2016

Member

Out in 15.4.0.

Member

gaearon commented Nov 16, 2016

Out in 15.4.0.

@malantonio malantonio referenced this pull request Jan 16, 2017

Merged

Add search results table #109

4 of 4 tasks complete

jstejada added a commit to nylas/nylas-mail that referenced this pull request Feb 10, 2017

fix(specs) Use shallow rendering
Now that we have 15.4.2, we don't have to worry about:
facebook/react#8097

acusti added a commit to brandcast/react that referenced this pull request Mar 15, 2017

Shares debugID information across modules (#8097)
Prior to this, React was using a nextDebugID variable that was locally
scoped to both `instantiateReactComponent` and `ReactShallowRenderer`.
This caused problems when the debugIDs would collide, the `itemMap` in
`ReactComponentTreeHook` would be overwritten and tests would fail
with the message "Expected onBeforeMountComponent() parent and
onSetChildren() to be consistent".

This change shares the debugID with both modules thus preventing any
collisions in the future.

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v16 #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment