Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Commoner and Recast to latest versions #81

Merged

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Jun 11, 2013

The Commoner upgrade is a big one because it makes bin/jsx no longer rewrite module identifiers to be relative by default, which should reduce confusion for people trying to use it as a standalone transformer.

Closes #80.

The Commoner upgrade is a big one because it makes bin/jsx no longer
rewrite module identifiers to be relative by default, which should
reduce confusion for people trying to use it as a standalone
transformer.

Closes facebook#80.
@petehunt
Copy link
Contributor

Thanks man! I think this will prevent future confusion for people, appreciate the quick turnaround :)

@benjamn
Copy link
Contributor Author

benjamn commented Jun 11, 2013

It also shaves ~50ms of time off bin/jsx startup, because it no longer has to require("recast"). That's not noticeable if you're compiling more than a few files, but it's nice to keep trivial compilations feeling instantaneous.

petehunt added a commit that referenced this pull request Jun 11, 2013
…tes-require

Upgrade Commoner and Recast to latest versions
@petehunt petehunt merged commit 94fdf2c into facebook:master Jun 11, 2013
bvaughn pushed a commit to bvaughn/react that referenced this pull request Aug 13, 2019
Show owner in DOM highilght overlay
taneliang referenced this pull request in MLH-Fellowship/react Aug 17, 2020
taneliang referenced this pull request in MLH-Fellowship/react Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bin/jsx should not relativize required module IDs unless --relativize is passed
2 participants