From 8a7afef9b8b92a641a682e5f2c4ba1e970a07e87 Mon Sep 17 00:00:00 2001 From: Tetsuharu OHZEKI Date: Wed, 2 Nov 2016 02:21:23 +0900 Subject: [PATCH] [Fiber] Assign ReactTypeOfSideEffect to ReactFiber.Fiber.effectTag correctly The type of `ReactFiber.Fiber.effectTag` is `TypeOfSideEffect`. Thus we should assign `ReactTypeOfSideEffect.NoEffect` value instead of `ReactPriorityLevel.NoWork` even if they are same values. --- src/renderers/shared/fiber/ReactChildFiber.js | 8 ++------ src/renderers/shared/fiber/ReactFiberScheduler.js | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/renderers/shared/fiber/ReactChildFiber.js b/src/renderers/shared/fiber/ReactChildFiber.js index 4468c28aed4c..ba4adbadc4ac 100644 --- a/src/renderers/shared/fiber/ReactChildFiber.js +++ b/src/renderers/shared/fiber/ReactChildFiber.js @@ -23,7 +23,6 @@ var { } = require('ReactCoroutine'); var ReactFiber = require('ReactFiber'); -var ReactPriorityLevel = require('ReactPriorityLevel'); var ReactReifiedYield = require('ReactReifiedYield'); var ReactTypeOfSideEffect = require('ReactTypeOfSideEffect'); var ReactTypeOfWork = require('ReactTypeOfWork'); @@ -56,10 +55,7 @@ const { } = ReactTypeOfWork; const { - NoWork, -} = ReactPriorityLevel; - -const { + NoEffect, Placement, Deletion, } = ReactTypeOfSideEffect; @@ -179,7 +175,7 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) { // we're reconciling at a lower priority that means that this was // down-prioritized. fiber.pendingWorkPriority = priority; - fiber.effectTag = NoWork; + fiber.effectTag = NoEffect; fiber.index = 0; fiber.sibling = null; return fiber; diff --git a/src/renderers/shared/fiber/ReactFiberScheduler.js b/src/renderers/shared/fiber/ReactFiberScheduler.js index 4c7b0c515422..1810de9c76f0 100644 --- a/src/renderers/shared/fiber/ReactFiberScheduler.js +++ b/src/renderers/shared/fiber/ReactFiberScheduler.js @@ -129,7 +129,7 @@ module.exports = function(config : HostConfig) { commitInsertion(effectfulFiber); // Clear the effect tag so that we know that this is inserted, before // any life-cycles like componentDidMount gets called. - effectfulFiber.effectTag = NoWork; + effectfulFiber.effectTag = NoEffect; break; } case PlacementAndUpdate: {