New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 4 extra SVG tags #819

Merged
merged 4 commits into from Jan 6, 2014

Conversation

Projects
None yet
6 participants
@mtharrison
Contributor

mtharrison commented Jan 5, 2014

I added support for the following SVG tags:

stop, defs, linearGradient, radialGradient.

@plievone

This comment has been minimized.

Show comment
Hide comment
Contributor

plievone commented Jan 5, 2014

Show outdated Hide outdated docs/docs/ref-04-tags-and-attributes.md
@@ -31,7 +31,7 @@ title tr track u ul var video wbr
The following SVG elements are supported:
```
circle g line path polygon polyline rect svg text
circle g line path polygon polyline rect svg text defs radialGradient linearGradient stop

This comment has been minimized.

@sophiebits

sophiebits Jan 5, 2014

Member

Can you alphabetize these? Also please wrap to 80 chars.

@sophiebits

sophiebits Jan 5, 2014

Member

Can you alphabetize these? Also please wrap to 80 chars.

@zpao

This comment has been minimized.

Show comment
Hide comment
Member

zpao commented Jan 6, 2014

@mtharrison

This comment has been minimized.

Show comment
Hide comment
@mtharrison

mtharrison Jan 6, 2014

Contributor

Sorry, I should've grep'd the project for all these instances. Updated now.

Contributor

mtharrison commented Jan 6, 2014

Sorry, I should've grep'd the project for all these instances. Updated now.

vjeux added a commit that referenced this pull request Jan 6, 2014

@vjeux vjeux merged commit 9454282 into facebook:master Jan 6, 2014

@dizzy0ny

This comment has been minimized.

Show comment
Hide comment
@dizzy0ny

dizzy0ny Mar 20, 2015

at the risk of possibly not knowing what i'm talking about...rather than have to add support for every attribute, couldn't you just test for existence of an attribute and simply set it on the 'transformed svg' if it is a valid attribute?

at the risk of possibly not knowing what i'm talking about...rather than have to add support for every attribute, couldn't you just test for existence of an attribute and simply set it on the 'transformed svg' if it is a valid attribute?

@mtharrison mtharrison deleted the mtharrison:add-more-svg-tags branch May 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment