benchmark runner & comparison tool with grunt commands and travis integration #821

Merged
merged 1 commit into from Jan 7, 2014

Conversation

Projects
None yet
4 participants
@subtleGradient
Contributor

subtleGradient commented Jan 5, 2014

No description provided.

@sophiebits

View changes

package.json
+ "grunt-complexity": "~0.1.3",
+ "benchmark": "~1.0.0",
+ "platform": "~1.0.0",
+ "microtime": "~0.5.1"

This comment has been minimized.

Show comment Hide comment
@sophiebits

sophiebits Jan 5, 2014

Member

resort this list?

@sophiebits

sophiebits Jan 5, 2014

Member

resort this list?

This comment has been minimized.

Show comment Hide comment
@subtleGradient

subtleGradient Jan 5, 2014

Contributor

will do

@subtleGradient

subtleGradient Jan 5, 2014

Contributor

will do

@plievone

This comment has been minimized.

Show comment Hide comment
@plievone

plievone Jan 5, 2014

Contributor

Do you know if there's any possibility to also benchmark memory use? Perf might increase by adding caches etc., which might be sad for e.g. memory-constrained mobile browsers. Possibly an overkill though.

Contributor

plievone commented Jan 5, 2014

Do you know if there's any possibility to also benchmark memory use? Perf might increase by adding caches etc., which might be sad for e.g. memory-constrained mobile browsers. Possibly an overkill though.

@subtleGradient

This comment has been minimized.

Show comment Hide comment
@subtleGradient

subtleGradient Jan 6, 2014

Contributor

Yes. I plan to add some memory profiling stuff soon. That'll be a bit tricky though since it requires passing command line flags to chrome. I'm not sure if sauce labs supports that yet.

Contributor

subtleGradient commented Jan 6, 2014

Yes. I plan to add some memory profiling stuff soon. That'll be a bit tricky though since it requires passing command line flags to chrome. I'm not sure if sauce labs supports that yet.

@subtleGradient

This comment has been minimized.

Show comment Hide comment
@subtleGradient

This comment has been minimized.

Show comment Hide comment
@subtleGradient

subtleGradient Jan 6, 2014

Contributor

The unit tests are currently failing on master, this diff contains no changes to any React source.

Contributor

subtleGradient commented Jan 6, 2014

The unit tests are currently failing on master, this diff contains no changes to any React source.

@petehunt

This comment has been minimized.

Show comment Hide comment
@petehunt

petehunt Jan 7, 2014

Contributor

i tested it and it printed json to stdout. and running regular grunt still works

Contributor

petehunt commented Jan 7, 2014

i tested it and it printed json to stdout. and running regular grunt still works

petehunt added a commit that referenced this pull request Jan 7, 2014

Merge pull request #821 from subtleGradient/subtlegradient/perf-task
benchmark runner & comparison tool with grunt commands and travis integration

@petehunt petehunt merged commit 57f208e into facebook:master Jan 7, 2014

1 check failed

default The Travis CI build failed
Details

@subtleGradient subtleGradient deleted the subtleGradient:subtlegradient/perf-task branch Jan 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment