From 2cefa30e7db147206f66d49841d055be77f4407b Mon Sep 17 00:00:00 2001 From: Robin Ricard Date: Wed, 16 Nov 2016 18:41:43 +0100 Subject: [PATCH] Change test assertion depending on a feature flag Instead of a private API (see https://github.com/facebook/react/pull/8150#discussion_r88280994) --- .../classic/element/__tests__/ReactElement-test.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/isomorphic/classic/element/__tests__/ReactElement-test.js b/src/isomorphic/classic/element/__tests__/ReactElement-test.js index 80f09d69a6d2..b16775f7083e 100644 --- a/src/isomorphic/classic/element/__tests__/ReactElement-test.js +++ b/src/isomorphic/classic/element/__tests__/ReactElement-test.js @@ -14,6 +14,7 @@ var React; var ReactDOM; var ReactTestUtils; +var ReactDOMFeatureFlags; describe('ReactElement', () => { var ComponentClass; @@ -30,6 +31,7 @@ describe('ReactElement', () => { React = require('React'); ReactDOM = require('ReactDOM'); ReactTestUtils = require('ReactTestUtils'); + ReactDOMFeatureFlags = require('ReactDOMFeatureFlags'); // NOTE: We're explicitly not using JSX here. This is intended to test // classic JS without JSX. ComponentClass = React.createClass({ @@ -266,9 +268,9 @@ describe('ReactElement', () => { React.createElement(Wrapper) ); - if (typeof element._owner.tag === 'number') { // Fiber reconciler + if (ReactDOMFeatureFlags.useFiber) { expect(element._owner.stateNode).toBe(instance); - } else { // Stack reconciler + } else { expect(element._owner.getPublicInstance()).toBe(instance); } });