Fix test renderer unmount #8512

Merged
merged 3 commits into from Dec 14, 2016

Conversation

Projects
None yet
4 participants
@gre
Contributor

gre commented Dec 7, 2016

Fixes #8459

gre added a commit to gre/gl-react that referenced this pull request Dec 7, 2016

_destroyGLObjects() only call dispose if gl is available
this is a workaround for tests to pass, as soon as React have this fixed facebook/react#8512

gre added a commit to gre/gl-react that referenced this pull request Dec 7, 2016

_destroyGLObjects() only call dispose if gl is available
this is a workaround for tests to pass ( stackgl/headless-gl#90 ), as soon as React have this fixed facebook/react#8512

@aweary aweary self-assigned this Dec 9, 2016

@aweary

aweary approved these changes Dec 9, 2016

Thanks for this @gre! LGTM

@aweary

This comment has been minimized.

Show comment
Hide comment
@aweary

aweary Dec 9, 2016

Member

@gre can you run the scripts/fiber/record-test script and add the results to this please? I think we can merge afterwards

Member

aweary commented Dec 9, 2016

@gre can you run the scripts/fiber/record-test script and add the results to this please? I think we can merge afterwards

@gre

This comment has been minimized.

Show comment
Hide comment
@gre

gre Dec 9, 2016

Contributor

done

Contributor

gre commented Dec 9, 2016

done

@aweary aweary merged commit 931cad5 into facebook:master Dec 14, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 85.159%
Details
@aweary

This comment has been minimized.

Show comment
Hide comment
@aweary

aweary Dec 14, 2016

Member

Thanks again @gre!

Member

aweary commented Dec 14, 2016

Thanks again @gre!

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Feb 6, 2017

Member

@aweary

Please always set the "next" (non-specific) milestone when merging. Otherwise the release tool won't see the pull request and we'll keep skipping it until the next major.

Member

gaearon commented Feb 6, 2017

@aweary

Please always set the "next" (non-specific) milestone when merging. Otherwise the release tool won't see the pull request and we'll keep skipping it until the next major.

@gaearon gaearon added this to the 15-hipri milestone Feb 6, 2017

bvaughn added a commit that referenced this pull request Mar 29, 2017

Fix test renderer unmount (#8512)
* [react-test-renderer] unmount the inner instances

Fixes #8459

* add a test for #8459

* add new test in tests-passing.txt

@renovate renovate bot referenced this pull request in signavio/backbone-rel Feb 2, 2018

Open

Update dependency react to v16 #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment