-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test renderer unmount #8512
Conversation
this is a workaround for tests to pass, as soon as React have this fixed facebook/react#8512
this is a workaround for tests to pass ( stackgl/headless-gl#90 ), as soon as React have this fixed facebook/react#8512
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @gre! LGTM
@gre can you run the |
done |
Thanks again @gre! |
Please always set the "next" (non-specific) milestone when merging. Otherwise the release tool won't see the pull request and we'll keep skipping it until the next major. |
Fixes #8459