Closure Compiler wrong assignment order in `instantiateReactComponent` #8895

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
3 participants
@anmonteiro
Contributor

anmonteiro commented Jan 30, 2017

This fixes #8894

@anmonteiro

This comment has been minimized.

Show comment
Hide comment
@anmonteiro

anmonteiro Feb 5, 2017

Contributor

Can we get this reviewed? This simple change alone can go a long way empowering Google Closure Compiler users to get dead-code elimination on React by consuming it from a node_modules installation.

Contributor

anmonteiro commented Feb 5, 2017

Can we get this reviewed? This simple change alone can go a long way empowering Google Closure Compiler users to get dead-code elimination on React by consuming it from a node_modules installation.

@anmonteiro anmonteiro changed the title from Change the order between function declaration and object assignment to Closure Compiler wrong assignment order in `instantiateReactComponent` Feb 5, 2017

@gaearon gaearon added this to the 15-hipri milestone Feb 6, 2017

@gaearon gaearon merged commit 4313059 into facebook:master Feb 6, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Feb 6, 2017

Member

This looks fine by itself. However, just to set expectations, I’m not quite sure when we’ll cut another patch release, and React 16 will contain a completely rewritten core, so this change won’t affect it.

Member

gaearon commented Feb 6, 2017

This looks fine by itself. However, just to set expectations, I’m not quite sure when we’ll cut another patch release, and React 16 will contain a completely rewritten core, so this change won’t affect it.

@anmonteiro anmonteiro deleted the anmonteiro:react-8894 branch Feb 6, 2017

@anmonteiro

This comment has been minimized.

Show comment
Hide comment
@anmonteiro

anmonteiro Feb 6, 2017

Contributor

Thanks!

I understand. So to avoid encountering similar problems with Fiber, are there instructions to build master locally and take it for a spin?

Contributor

anmonteiro commented Feb 6, 2017

Thanks!

I understand. So to avoid encountering similar problems with Fiber, are there instructions to build master locally and take it for a spin?

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Feb 6, 2017

Member

@anmonteiro

Yea. You should be able to build from master and then import react-dom/fiber instead of react-dom.

Member

gaearon commented Feb 6, 2017

@anmonteiro

Yea. You should be able to build from master and then import react-dom/fiber instead of react-dom.

@anmonteiro

This comment has been minimized.

Show comment
Hide comment
@anmonteiro

anmonteiro Feb 6, 2017

Contributor

Great. Will do and report any issues I encounter along the way.

Contributor

anmonteiro commented Feb 6, 2017

Great. Will do and report any issues I encounter along the way.

@anmonteiro

This comment has been minimized.

Show comment
Hide comment
@anmonteiro

anmonteiro Feb 7, 2017

Contributor

@gaearon Don't know where else to provide feedback, but everything seems to work successfully when consuming ReactDOMFiber with the Google Closure Compiler 👍

Contributor

anmonteiro commented Feb 7, 2017

@gaearon Don't know where else to provide feedback, but everything seems to work successfully when consuming ReactDOMFiber with the Google Closure Compiler 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment