New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print newline after doc comments before attributes #1869
Print newline after doc comments before attributes #1869
Conversation
0c99054
to
d67556c
Compare
Rebased and added an additional test case for short multi-line doc comments preceding externals. |
cc @rickyvetter |
Are there sufficient test cases on non-extern items that have doc comments? (Like type definitions and regular let bindings?) If not, would you care to add them so I can merge? |
I added more tests for doc comments on type and let statements. Let me know if there are any others you might like to see. |
@jordwalke Did you have any other issues with this patch? |
Forces a line break following doc comments before the first non-comment attribute on a BuckleScript external. Before: /** doc comment */ [@bs.send] external url : t => string = ""; /** * Short multiline doc comment */ [@bs.send] external url : t => string = ""; After: /** doc comment */ [@bs.send] external url : t => string = ""; /** * Short multiline doc comment */ [@bs.send] external url : t => string = "";
Doc comments were previously disabled.
a3c8c51
to
3ad1c82
Compare
I rebased this on master and reworked it to use |
Good stuff. Thanks @zploskey! |
Forces a line break following doc comments before the first non-comment attribute on a BuckleScript external.
Before:
After:
Fixes #1857.