Reset rather than delete sent field on next #208

Merged
merged 1 commit into from Jun 25, 2015

Projects

None yet

3 participants

@kpdecker
Contributor

Delete was causing deoptimization due to backing class change and was unnecessary as this field was explicitly initialized to undefined and was not being checked for existence as best I can tell.

When combined with #207 saw a 40x throughput improvement under FF, from 39k operations/sec to 1.6M ops/src on http://kpdecker.github.io/six-speed/

@kpdecker kpdecker Reset rather than delete sent field on next
Delete was causing deoptimization due to backing class change and was unnecessary as this field was explicitly initialized to undefined and was not being checked for existence as best I can tell.

When combined with #207 saw a 40x throughput improvement under FF, from 39k operations/sec to 1.6M ops/src on http://kpdecker.github.io/six-speed/
7008d2a
@kpdecker
Contributor

Similarly, under Chrome the execution went from 39k ops/sec to 674k ops/sec.

@benjamn benjamn merged commit e698f12 into facebook:master Jun 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benjamn
Member
benjamn commented Jun 25, 2015

Thanks a ton! That speedup is impressive.

@benjamn benjamn added a commit to benjamn/babel that referenced this pull request Jun 29, 2015
@benjamn benjamn Upgrade Regenerator to 0.8.32.
This includes some major runtime performance improvements:
facebook/regenerator#207
facebook/regenerator#208

And also some bug fixes relating to async generator functions:
facebook/regenerator@29d81b6
facebook/regenerator@7d2a052
facebook/regenerator@5b9dd10
b9f6169
@benjamn benjamn referenced this pull request in babel/babel Jun 29, 2015
Merged

Upgrade Regenerator to 0.8.32. #1868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment