Expose way to override isGeneratedFile function via language plugin. #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone had time to look at this? |
… deletion of files marked as generated.
There was a problem hiding this comment.
@alunyov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jstejada
pushed a commit
that referenced
this pull request
Feb 13, 2020
…2810) Summary: This PR lets language plugins override `isGeneratedFile`. My use case is emitting ReasonML types, where the generated files need to be called `SomeModule_graphql.re` rather than `SomeModule.graphql.re`, since ReasonML does not accept `.` in the file name other than for the extension. Pull Request resolved: #2810 Reviewed By: kassens Differential Revision: D19834002 Pulled By: alunyov fbshipit-source-id: 34e71eb20425ab5dd699481e988ed4a9662ceab5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets language plugins override
isGeneratedFile. My use case is emitting ReasonML types, where the generated files need to be calledSomeModule_graphql.rerather thanSomeModule.graphql.re, since ReasonML does not accept.in the file name other than for the extension.