Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run update-spec in website package to update connections spec #2819

Closed
wants to merge 1 commit into from

Conversation

merrywhether
Copy link
Contributor

As referenced in #2457, the connections spec markdown file is up-to-date but the published artifact related to it is not. This PR just runs yarn update-spec in the website package in order to get the spec site back in sync with the current version of the spec.

This was the simplest solution to the immediate problem, but is not long term. I could see a more robust solution that removes website/static/graphql from the git repo entirely and moves yarn update-spec (maybe renamed to yarn generate-spec or something) into the circleCI config so that the html artifacts are generated during the publish and thus cannot get out of sync, but I did not want to overstep (though could easily wire that up as a follow-up if desired).

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kassens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kassens
Copy link
Member

kassens commented Aug 8, 2019

Thanks, good catch!

@facebook-github-bot
Copy link
Contributor

@kassens merged this pull request in d5d60e7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants