Run update-spec in website package to update connections spec#2819
Closed
merrywhether wants to merge 1 commit into
Closed
Run update-spec in website package to update connections spec#2819merrywhether wants to merge 1 commit into
merrywhether wants to merge 1 commit into
Conversation
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@kassens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
Thanks, good catch! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As referenced in #2457, the connections spec markdown file is up-to-date but the published artifact related to it is not. This PR just runs
yarn update-specin the website package in order to get the spec site back in sync with the current version of the spec.This was the simplest solution to the immediate problem, but is not long term. I could see a more robust solution that removes
website/static/graphqlfrom the git repo entirely and movesyarn update-spec(maybe renamed toyarn generate-specor something) into the circleCI config so that the html artifacts are generated during the publish and thus cannot get out of sync, but I did not want to overstep (though could easily wire that up as a follow-up if desired).