Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curry printRequireModuleDependency with extension; add relative ./ path #2846

Closed

Conversation

@babangsund
Copy link
Contributor

babangsund commented Sep 9, 2019

Suggested fix for #2713

@babangsund babangsund force-pushed the babangsund:operation-require-extension branch 3 times, most recently from f2c3e72 to 5a5b1ee Sep 10, 2019
Copy link

facebook-github-bot left a comment

@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@babangsund

This comment has been minimized.

Copy link
Contributor Author

babangsund commented Sep 13, 2019

Not being able to see what tests and linters are failing on internally is kind of annoying. 😅

@babangsund babangsund force-pushed the babangsund:operation-require-extension branch from 5a5b1ee to 502a0b6 Sep 13, 2019
Copy link

facebook-github-bot left a comment

@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@babangsund babangsund deleted the babangsund:operation-require-extension branch Sep 13, 2019
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Sep 13, 2019

@alunyov merged this pull request in 2a18222.

@mrtnzlml

This comment has been minimized.

Copy link
Contributor

mrtnzlml commented Sep 19, 2019

@babangsund This creates the following path:

"operation": require('./LocationsPaginatedRefetchRefetchQuery.graphqljs'),

There is a missing dot for the extension, it should be this:

- "operation": require('./LocationsPaginatedRefetchRefetchQuery.graphqljs'),
+ "operation": require('./LocationsPaginatedRefetchRefetchQuery.graphql.js'),
@sibelius

This comment has been minimized.

Copy link
Collaborator

sibelius commented Sep 19, 2019

@mrtnzlml can you send a pr fixing this?

@mrtnzlml

This comment has been minimized.

Copy link
Contributor

mrtnzlml commented Sep 19, 2019

@sibelius Cannot promise. Is there already some existing test for this file or should I create a new test?

@sibelius

This comment has been minimized.

Copy link
Collaborator

sibelius commented Sep 19, 2019

you can add another test

@babangsund babangsund referenced this pull request Sep 19, 2019
facebook-github-bot added a commit that referenced this pull request Oct 21, 2019
Summary:
Oops. #2846 (comment)
Pull Request resolved: #2861

Reviewed By: alunyov

Differential Revision: D18015465

Pulled By: jstejada

fbshipit-source-id: 8618ad27efe3f61eb5d1c6ee08c8e11a1d9c21bb
jstejada added a commit that referenced this pull request Oct 21, 2019
Summary:
Oops. #2846 (comment)
Pull Request resolved: #2861

Reviewed By: alunyov

Differential Revision: D18015465

Pulled By: jstejada

fbshipit-source-id: 8618ad27efe3f61eb5d1c6ee08c8e11a1d9c21bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.