Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCurry printRequireModuleDependency with extension; add relative ./ path #2846
Conversation
babangsund
force-pushed the
babangsund:operation-require-extension
branch
3 times, most recently
from
f2c3e72
to
5a5b1ee
facebook-github-bot left a comment
|
@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This comment has been minimized.
This comment has been minimized.
|
Not being able to see what tests and linters are failing on internally is kind of annoying. |
babangsund
force-pushed the
babangsund:operation-require-extension
branch
from
5a5b1ee
to
502a0b6
facebook-github-bot left a comment
|
@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This comment has been minimized.
This comment has been minimized.
facebook-github-bot
commented
Sep 13, 2019
This comment has been minimized.
This comment has been minimized.
|
@babangsund This creates the following path: There is a missing dot for the extension, it should be this: - "operation": require('./LocationsPaginatedRefetchRefetchQuery.graphqljs'),
+ "operation": require('./LocationsPaginatedRefetchRefetchQuery.graphql.js'), |
This comment has been minimized.
This comment has been minimized.
|
@mrtnzlml can you send a pr fixing this? |
This comment has been minimized.
This comment has been minimized.
|
@sibelius Cannot promise. Is there already some existing test for this file or should I create a new test? |
This comment has been minimized.
This comment has been minimized.
|
you can add another test |
Closed
facebook-github-bot
added a commit
that referenced
this pull request
Oct 21, 2019
Summary: Oops. #2846 (comment) Pull Request resolved: #2861 Reviewed By: alunyov Differential Revision: D18015465 Pulled By: jstejada fbshipit-source-id: 8618ad27efe3f61eb5d1c6ee08c8e11a1d9c21bb
jstejada
added a commit
that referenced
this pull request
Oct 21, 2019
Summary: Oops. #2846 (comment) Pull Request resolved: #2861 Reviewed By: alunyov Differential Revision: D18015465 Pulled By: jstejada fbshipit-source-id: 8618ad27efe3f61eb5d1c6ee08c8e11a1d9c21bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
babangsund commentedSep 9, 2019
•
edited
Suggested fix for #2713