New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curry printRequireModuleDependency with extension; add relative ./ path #2846
Conversation
f2c3e72
to
5a5b1ee
Compare
@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Not being able to see what tests and linters are failing on internally is kind of annoying. |
5a5b1ee
to
502a0b6
Compare
@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@babangsund This creates the following path:
There is a missing dot for the extension, it should be this: - "operation": require('./LocationsPaginatedRefetchRefetchQuery.graphqljs'),
+ "operation": require('./LocationsPaginatedRefetchRefetchQuery.graphql.js'), |
@mrtnzlml can you send a pr fixing this? |
@sibelius Cannot promise. Is there already some existing test for this file or should I create a new test? |
you can add another test |
Summary: Oops. #2846 (comment) Pull Request resolved: #2861 Reviewed By: alunyov Differential Revision: D18015465 Pulled By: jstejada fbshipit-source-id: 8618ad27efe3f61eb5d1c6ee08c8e11a1d9c21bb
Summary: Oops. #2846 (comment) Pull Request resolved: #2861 Reviewed By: alunyov Differential Revision: D18015465 Pulled By: jstejada fbshipit-source-id: 8618ad27efe3f61eb5d1c6ee08c8e11a1d9c21bb
Suggested fix for #2713