From 5997f6b17bfe571a5882f2f490d81cf5c6b44732 Mon Sep 17 00:00:00 2001 From: Akanksha Mahajan Date: Wed, 30 Sep 2020 12:46:34 -0700 Subject: [PATCH] Add Status check enforcement for unit tests (#7464) Summary: Add status check for unit tests : block_based_filter_block_test, block_fetcher_test, full_filter_block_test and partitioned_filter_block_test Pull Request resolved: https://github.com/facebook/rocksdb/pull/7464 Reviewed By: zhichao-cao Differential Revision: D24011309 Pulled By: akankshamahajan15 fbshipit-source-id: d814803f94e8bb8b811ef170d20b22d52c1a3ff2 --- Makefile | 4 ++++ table/block_fetcher_test.cc | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 876d056e427..798580df822 100644 --- a/Makefile +++ b/Makefile @@ -647,6 +647,10 @@ ifdef ASSERT_STATUS_CHECKED merge_helper_test \ memtable_list_test \ flush_job_test \ + block_based_filter_block_test \ + block_fetcher_test \ + full_filter_block_test \ + partitioned_filter_block_test \ ifeq ($(USE_FOLLY_DISTRIBUTED_MUTEX),1) TESTS_PASSING_ASC += folly_synchronization_distributed_mutex_test diff --git a/table/block_fetcher_test.cc b/table/block_fetcher_test.cc index f8cbad6d014..0786730af64 100644 --- a/table/block_fetcher_test.cc +++ b/table/block_fetcher_test.cc @@ -295,8 +295,9 @@ class BlockFetcherTest : public testing::Test { uint64_t file_size = 0; ASSERT_OK(env_->GetFileSize(file->file_name(), &file_size)); IOOptions opts; - ReadFooterFromFile(opts, file, nullptr /* prefetch_buffer */, file_size, - footer, kBlockBasedTableMagicNumber); + ASSERT_OK(ReadFooterFromFile(opts, file, nullptr /* prefetch_buffer */, + file_size, footer, + kBlockBasedTableMagicNumber)); } // NOTE: compression_type returns the compression type of the fetched block