Gcc-7 buffer size insufficient #1673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gcc error:
util/transaction_test_util.cc:188:8: error: output may be truncated before the last format character [-Werror=format-length=]
Status RandomTransactionInserter::Verify(DB* db, uint16_t num_sets) {
^~~~~~~~~~~~~~~~~~~~~~~~~
util/transaction_test_util.cc:194:60: note: format output between 5 and 6 bytes into a destination of size 5
snprintf(prefix_buf, sizeof(prefix_buf), "%.4u", i + 1);
Error:
utilities/transactions/transaction_util.cc:53:8: error: output may be truncated before the last format character [-Werror=format-length=]
Status TransactionUtil::CheckKey(DBImpl* db_impl, SuperVersion* sv,
^~~~~~~~~~~~~~~
utilities/transactions/transaction_util.cc:94:38: note: format output between 257 and 295 bytes into a destination of size 255
key_seq, earliest_seq);
gcc-7 error:
utilities/simulator_cache/sim_cache.cc:135:23: error: '%%' directive output truncated while writing 1 byte into a region of size 0 [-Werror=format-length=]
virtual std::string ToString() const override {
^~~~~~~~
utilities/simulator_cache/sim_cache.cc:142:72: note: format output between 25 and 334 bytes into a destination of size 100
(lookups == 0 ? 0 : get_hit_counter() * 100.0f / lookups));
gcc-7 error:
tools/db_bench_tool.cc: In member function 'void rocksdb::Benchmark::Compress(rocksdb::ThreadState*)':
tools/db_bench_tool.cc:2598:8: error: '%%' directive output truncated while writing 1 byte into a region of size 0 [-Werror=format-length=]
void Compress(ThreadState *thread) {
^~~~~~~~
tools/db_bench_tool.cc:2620:43: note: format output between 15 and 324 bytes into a destination of size 100
(produced * 100.0) / bytes);
^
cc1plus: all warnings being treated as errors
Makefile:1521: recipe for target 'tools/db_bench_tool.o' failed
make: *** [tools/db_bench_tool.o] Error 1
IslamAbdelRahman
approved these changes
Dec 15, 2016
|
@IslamAbdelRahman has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of commits related to insufficient buffer size. Errors in individual commits.