Use cmake TIMESTAMP function #2848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
reviewed
Sep 8, 2017
CMakeLists.txt
Outdated
| string(REGEX REPLACE "\n" "" DATETIME ${DATETIME}) | ||
| set(GIT_DATE_TIME "${DATETIME}") | ||
| endif() | ||
| string(TIMESTAMP ${GIT_DATE_TIME} "%Y/%m/%d %H:%M:%S" UTC) |
There was a problem hiding this comment.
I think you need to update cmake_minimum_required to use TIMESTAMP.
|
@bmwiedemann updated the pull request - view changes |
|
LGTM |
because it is not only platform independent but also allows to override the build date to make ceph builds reproducible Requires cmake-2.8.11+ from 2013
|
@bmwiedemann updated the pull request - view changes |
|
Merging. |
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
BusyJay
pushed a commit
to BusyJay/rocksdb
that referenced
this pull request
Nov 21, 2017
Summary: because it is not only platform independent but also allows to override the build date This helps to make ceph builds reproducible (that includes a fork of rockdb in a submodule) Also adds UTC flag, to be independent of timezone. Requires cmake-2.8.11+ from 2013 Closes facebook#2848 Differential Revision: D5820189 Pulled By: yiwu-arbug fbshipit-source-id: e3e8c1550e10e238c173f6c5d9ba15f71ad3ce28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
because it is not only platform independent
but also allows to override the build date
This helps to make ceph builds reproducible (that includes a fork of rockdb in a submodule)
Also adds UTC flag, to be independent of timezone.
Requires cmake-2.8.11+ from 2013